From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 415A03858C27 for ; Tue, 26 Oct 2021 01:28:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 415A03858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: nGbyrsJkLgzlaOVjKMA/juODciC7Mn1oc9EPkGLIVDjf4vtMPy0SY8qw1/F1mnTpyqkyFD6XN0 2BWTz5ooEXdQtARTZsdLB4D/6Qs3lz2yl2EwJGpuIak+ohg3E5aKv6DP2bCxKgafIYAkchPETY u3hLg9Q1KlnX5cspMyUCr2N8CBY4MRRo3xyPG2hwu6ItT14/dfvWA0BAIe9QJp1IdCkQcF4fcO zzmMzaHwoQc/YFQgbtYqEcdgRS7q2VQHEvvGRbxW8Ifak4PthqenAXrFMU8TdjWPT9OCwTsOhZ rOKzyURmhAZvWgvunMM5acyc X-IronPort-AV: E=Sophos;i="5.87,181,1631606400"; d="scan'208";a="67624132" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 25 Oct 2021 17:28:18 -0800 IronPort-SDR: vEmVr1NXUZxlhLO6jABFawGvGOlIL15mfR0K2Pa9lsMG6sZQ4qELeKSdONlg0/O2TYLX1pPySI psEx4GjJExCVUfRTwOUHQVhx+sZTPw2AWWtOwOboJllBqRLn/5ssrV6hv4na2dSGHdjjMjAuIY fK3PMe+dWZv1bxJqRui9ar/XcMbw8HUeYxwBm7Qzkmq7HdKbPf1SejFFhAgdM74BRQT3EkBTS5 x7USQ/AJKh7XOW2jkpiK6JZtKrWf+IfMqMKOsrh+fvugRgOy8cziYxCdtiXbfad7/pVf09jSJq Ms4= Date: Tue, 26 Oct 2021 01:28:12 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Richard Biener CC: Jan-Benedict Glaw , Subject: Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS In-Reply-To: Message-ID: References: <20211023200005.xknhnzfa7eyny5zf@lug-owl.de> <20211024072015.gaemuuwr4z2cx2oh@lug-owl.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3117.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2021 01:28:21 -0000 On Mon, 25 Oct 2021, Richard Biener via Gcc-patches wrote: > So it looks like tm_d.h is much more stripped down compared to regular > tm_p.h but also oddly enough config/default-d.c includes tm_d.h > while config/default-c.c explicitely documents itself to not do that. I think the intent of that comment in default-c.c (which I wrote) was that if a separate tm_c.h is needed, it should use its own headers, disjoint from those used by tm.h. In particular, as noted in the original patch submission , that avoids making macros used only to define hooks visible throughout the compiler. > Is it maybe a bug that tm_d.h includes defaults.h at all? Should It's a bug that it includes defaults.h, and a bug that it includes ${cpu_type}/${cpu_type}.h. Any macros used only to define D hooks should be in completely separate headers that aren't used elsewhere in the compiler. > "d defaults" be in a defaults-d.h instead? If I remove the Yes, and likewise any target-specific overrides of such macros should be in a separate header, not ${cpu_type}/${cpu_type}.h. -- Joseph S. Myers joseph@codesourcery.com