From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 860B3385840E for ; Mon, 22 Nov 2021 20:56:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 860B3385840E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: D0YHShlLNxsdjaffJKDNSKl43qtWfHsKlluXfTcr2bQlFm6zbFC6b6JoHAb5gTFRBHh4GUewlT 2649JJFkFJ/lrQvvXSMMaDw8vAqoX6hy0HuYw+gpGRKjM3WOlXKZc4m7WFkXmAfghbS5u9jIaQ WdZnM6hONlpXjzKYF18VrS+SZpjaoSRFrpVbEAvWnzE/Rnv1tAiXlJYCzBqDnlnpWuMxgD9FzK dc4vXWqx+aRVNWODWQWfjbcAfyCRa3GcLU5cyDQg5opqJ5Hb3qiBtfu9sCTMuE+DbXdHPSZInT YW0maLuBUFf1y7ezXJisIc60 X-IronPort-AV: E=Sophos;i="5.87,255,1631606400"; d="scan'208";a="68660645" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 22 Nov 2021 12:56:18 -0800 IronPort-SDR: Fofl9jYNpOu8yA51m1ru6TdUGgZgoIbi5lHhh2pNlA9/zakkBS6mQo5XqnHDsNdE/VsHMOXPAH qmmxuZc2z1e1ZQD2LM/dIz26MNMC+TfbPiTaoO1GVi5JZ+TbIBYMD2PvV5i5VQ0osit83UgSet G2/Ru5wKGoLEw+TUajIlBaFrx07GF6crxVPG0I3sy/HROa05uYJ89FlF4PITJOy+H1mTC0v7EM BzlSl1CgSchflozdBhq1MQChw0abfSVyQ3gTC31xXlc22e0ggFy+FqUhu+BAbn3OceFa9qMxNE SMA= Date: Mon, 22 Nov 2021 20:56:12 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Jakub Jelinek CC: Tobias Burnus , gcc-patches Subject: Re: [PATCH] libcpp, v2: Fix _Pragma in #__VA_ARGS__ [PR103165] In-Reply-To: <20211122092329.GI2646553@tucnak> Message-ID: References: <5e77a918-1943-03dc-5bb7-20eebfc61226@codesourcery.com> <20211118112413.GR2710@tucnak> <20211122092329.GI2646553@tucnak> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3116.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 20:56:20 -0000 On Mon, 22 Nov 2021, Jakub Jelinek via Gcc-patches wrote: > On Thu, Nov 18, 2021 at 09:55:52PM +0000, Joseph Myers wrote: > > On Thu, 18 Nov 2021, Jakub Jelinek via Gcc-patches wrote: > > > > > Are we handling the pragma at a wrong phase of preprocessing? > > > > I think that converting it to a single preprocessing token (rather than > > four separate preprocessing tokens), at a stage when stringizing might > > still occur, does indicate it's being processed too soon, and it would be > > better to do that only when it's known that the _Pragma preprocessing > > token will actually occur in the results of preprocessing the source file. > > So like this? I.e. don't process _Pragma during expand_args where we can't > know what the macro will do with it? > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK. -- Joseph S. Myers joseph@codesourcery.com