From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id A6DBF3858D3C for ; Fri, 11 Mar 2022 20:55:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6DBF3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,174,1643702400"; d="scan'208";a="73070014" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 11 Mar 2022 12:55:37 -0800 IronPort-SDR: FtZBfC3NA7u9EZQP+t73oIn+GlyUefSeTkv5RK8yeTz/do2L4ZKLpjRuwvBLA1SG34euw955Bm Wxvm9XSiReZ4bQWTSk/Dkg4gHabXauMP2+9yr+ZjAuMyEFuP1P2bc6PwyWWfhyu8AvyR8vmhyV rGtz5Pvz3CpvjDfCYqhIXFEf7vJ3Z7jrHvQFlyeu4mwRJoLS8qmWG0WevRRqWmltkNjqF9YpuC rMwswTDbzIAg5mxxxtUDNIxAc7eID02vcPglMY0b0ITQuamOL9JGr3Fj2V/JiV7bXF0F+6ERhK NC8= Date: Fri, 11 Mar 2022 20:55:32 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Krishna Narayanan CC: Subject: Re: [PATCH] c : Changed warning message for -Wstrict-prototypes [PR92209] In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3114.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 20:55:40 -0000 On Fri, 11 Mar 2022, Krishna Narayanan via Gcc-patches wrote: > Hello, > The following is a patch for the PR92209,which gives a warning when > the function prototype does not specify its argument type.In this > patch there has been a change in the warning message displayed for > -Wstrict-prototypes to specify its argument types.I have also added > the testcase for it. > Regtested on x86_64,OK for commit? Please do review it. Why do you think your proposed wording is better than the existing wording? I think the existing wording is accurate and the proposed wording is inaccurate - "must specify the argument types" is not an accurate description of any requirement in the C language, using "must" at all generally seems questionable in the wording of a warning message. Also, I don't think this change is anything to do with the PR you mention ("Imprecise column number for -Wstrict-prototypes"), so it's wrong to mention that PR number in the proposed commit message. -- Joseph S. Myers joseph@codesourcery.com