From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <joseph_myers@mentor.com>
Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98])
 by sourceware.org (Postfix) with ESMTPS id E1368385741C
 for <gcc-patches@gcc.gnu.org>; Thu, 31 Mar 2022 17:17:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1368385741C
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.90,225,1643702400"; d="scan'208";a="73905626"
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])
 by esa2.mentor.iphmx.com with ESMTP; 31 Mar 2022 09:17:29 -0800
IronPort-SDR: iF3jJXH5BpbJQrzXCz2cHlcuAbJKt3izT0J1iYr9FMZDzfGmM/hFikuxreKGZ7pHMZHvo8+mxn
 LOgsfsHbI8NIkE3BLlIx6Ghps9l+gPhhxzQJlwBMt85mk3Wk1NSaNyiOri9WEI88cTVU7M7rDz
 JH4ZUaHOLUAD9jBwqWV5YI3u8AWgm0YiO++c00t55BZKI4nf35zXY+KivhC8yJ8kROXr4LQCK4
 cggnjSFTtBSY87c6XE7qWbKuBH7ywJVhf9u8v51BkzvEexL9JalBfSYsEqPZVLkYVyz97E8GY+
 d/E=
Date: Thu, 31 Mar 2022 17:17:25 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Thomas Schwinge <thomas@codesourcery.com>
CC: <gcc-patches@gcc.gnu.org>, =?ISO-8859-15?Q?Manuel_L=F3pez-Ib=E1=F1ez?=
 <lopezibanez@gmail.com>
Subject: Re: options: Fix "Multiple different help strings" error diagnostic
 (was: make conflicting help text an error)
In-Reply-To: <8735iz18bh.fsf@euler.schwinge.homeip.net>
Message-ID: <alpine.DEB.2.22.394.2203311717090.35304@digraph.polyomino.org.uk>
References: <CAESRpQAS8m0Gyy3LLZkiVjwoOs4OUYTzZAd3aHTdAwm-JH0F2Q@mail.gmail.com>
 <8735iz18bh.fsf@euler.schwinge.homeip.net>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-Spam-Status: No, score=-3114.0 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2022 17:17:32 -0000

On Wed, 30 Mar 2022, Thomas Schwinge wrote:

> > --- gcc/optc-gen.awk  (revision 187427)
> > +++ gcc/optc-gen.awk  (working copy)
> 
> >               else if (help[i] != "" && help[i + 1] != help[i])
> > -                     print "warning: multiple different help strings for " \
> > -                             opts[i] ":\n\t" help[i] "\n\t" help[i + 1] \
> > -                             | "cat 1>&2"
> > +                     print "#error Multiple different help strings for " \
> > +                             opts[i] ":\n\t" help[i] "\n\t" help[i + 1]
> > +
> 
> OK to push the attached 'options: Fix "Multiple different help strings"
> error diagnostic'?

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com