From: Joseph Myers <joseph@codesourcery.com>
To: Jason Merrill <jason@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH RFA] c-family: attribute ((aligned, mode)) [PR100545]
Date: Wed, 27 Apr 2022 17:02:09 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2204271700060.404671@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20220427151957.795214-1-jason@redhat.com>
On Wed, 27 Apr 2022, Jason Merrill via Gcc-patches wrote:
> + if (typedef_variant_p (type))
> + {
> + /* Set up the typedef all over again. */
This seems wrong when the typedef is just being used in another
declaration with the mode attribute, as opposed to being defined using the
mode attribute. E.g. the following test is valid and accepted before the
patch, but wrongly rejected after the patch because the typedef has had
its type changed.
typedef int I;
int x;
I y __attribute__ ((mode(QI)));
extern I x;
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-04-27 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 15:19 Jason Merrill
2022-04-27 16:58 ` Marek Polacek
2022-04-27 17:02 ` Joseph Myers [this message]
2022-04-27 23:48 ` Jason Merrill
2022-04-29 19:20 ` Jason Merrill
2022-04-29 19:46 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2204271700060.404671@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).