From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 0EA723858C55 for ; Thu, 23 Jun 2022 16:39:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0EA723858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.92,216,1650960000"; d="scan'208";a="77646267" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 23 Jun 2022 08:39:29 -0800 IronPort-SDR: nzohLwuTCU/TuA6QUMGZXJMyP/T2oZKN2wDLrRPLb4DQmaFtObdQIBw7PqQLJ65AHMKcjPNqgX hYEge8AEABVf1gUoPMzonjaWSminUoLYGmo3t7rFYiV13Y34ENIBr9s84RMskrCA8hIk7wBkBB T780BmAPrR9uXZLRgiWrI1isD8URRz1lpARm2uHeMAZn2YFEuAHjwWlAuPlSVujrarkD0yPGi5 RejyFhWgZMjuOuLqdhlOEbcPA+H7yq5lG5Lgo8OaQyYmUfTf0Gv/sjF+z7R/QYrB8pymSlQq39 M28= Date: Thu, 23 Jun 2022 16:39:23 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: David Malcolm CC: Subject: Re: [PATCH 03/12] Add more emit_diagnostic overloads In-Reply-To: <20220622223447.2462880-4-dmalcolm@redhat.com> Message-ID: References: <20220622223447.2462880-1-dmalcolm@redhat.com> <20220622223447.2462880-4-dmalcolm@redhat.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3112.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 16:39:31 -0000 On Wed, 22 Jun 2022, David Malcolm via Gcc-patches wrote: > extern bool emit_diagnostic (diagnostic_t, rich_location *, int, > const char *, ...) ATTRIBUTE_GCC_DIAG(4,5); > +extern bool emit_diagnostic (diagnostic_t, rich_location *, > + const diagnostic_metadata *, int, > + const char *, ...) ATTRIBUTE_GCC_DIAG(5,6); Note that functions that take translatable diagnostic strings (*msgid parameters) can't have overloads with the diagnostic string argument in different positions because that breaks xgettext (see commit 40fecdd62f7d293a214dd71b81de5e0f1099bba7). -- Joseph S. Myers joseph@codesourcery.com