From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id D67AB3858012 for ; Tue, 2 Aug 2022 16:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D67AB3858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,211,1654588800"; d="scan'208";a="80647337" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 02 Aug 2022 08:53:50 -0800 IronPort-SDR: FvcYmYeZnFQag8mCDo3/siIK1w7rMUNsQQ33zFkw+aU5jXJGgWn6nrnBle9/SAUu+J74uYnOHP Hhlpvojll+LXJ2RTUMoYtMKWfAIrqlbXKjwmCcKg5tV3Kb1DXuBP3+lnVR59MP60MdqR5G478J MkoYpvnsyehC77ZkRbNp0RcDilmc2/j3vt4nljYnZHJN1Q8iNwPXzKgXFSpKBdywKUunfN/yyr bAe4TC+xRhk0hFrCXvSJxmKaSRigUyK0Q7gxM7xbQJPDuHvLOREEqI2VHRQwSB9ic1laKxBYsV r7U= Date: Tue, 2 Aug 2022 16:53:46 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Tom Honermann CC: Subject: Re: [PATCH 2/3 v3] testsuite: Add tests for C2X N2653 char8_t and UTF-8 string literal changes In-Reply-To: <20220801223945.1433166-1-tom@honermann.net> Message-ID: References: <20220725175948.1424695-3-tom@honermann.net> <20220801223945.1433166-1-tom@honermann.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3112.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2022 16:53:54 -0000 On Mon, 1 Aug 2022, Tom Honermann via Gcc-patches wrote: > This change provides new tests for the core language and compiler > dependent library changes adopted for C2X via WG14 N2653. Could you please send a complete patch series? I'm not sure what the matching patches 1 and 3 are. Also, I don't generally find it helpful for tests to be separated from the patch making the changes they test, since tests are necessary to review of that code. -- Joseph S. Myers joseph@codesourcery.com