From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 01449385702B for ; Mon, 8 Aug 2022 20:02:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01449385702B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,222,1654588800"; d="scan'208";a="80975180" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 08 Aug 2022 12:01:51 -0800 IronPort-SDR: tj1VO2VWWN08U1xShnh14D1dAAJd04dv3kPRzsjoGA/ef+xGXyMxgz30IbKChXEdtcwylZKudx L+7Z+gIpOLDVeYPGKlsjN1JK4E+U5Ek5XReAyL37F4fCQVLIMwjCQK/VBeoz0cCmS7GGgGjS06 guh7+SSCh7K2so7XHRlcvXB8PdnJwrE4WB5hNXzPAKfoc/OB9JZKg5NRJM1fAQM+6+iOTISLIT o0SAIZFAKLv0En0AIUv+qHQNfJ+7n27Wb64hGjMZXmiaHDV233QCpqx3zaDUDvDPf54GE7lXE+ /ts= Date: Mon, 8 Aug 2022 20:01:46 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Tom Honermann CC: Subject: Re: [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals as unsigned in char8_t modes. In-Reply-To: <01b6ae2b-51b1-f5e9-53b9-b410b1bb7b26@honermann.net> Message-ID: References: <20220802183602.1575950-1-tom@honermann.net> <20220802183602.1575950-3-tom@honermann.net> <01b6ae2b-51b1-f5e9-53b9-b410b1bb7b26@honermann.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3112.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2022 20:02:02 -0000 On Mon, 8 Aug 2022, Tom Honermann via Gcc-patches wrote: > On 8/2/22 6:14 PM, Joseph Myers wrote: > > On Tue, 2 Aug 2022, Tom Honermann via Gcc-patches wrote: > > > > > This patch corrects handling of UTF-8 character literals in preprocessing > > > directives so that they are treated as unsigned types in char8_t enabled > > > C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). > > > Previously, > > > UTF-8 character literals were always treated as having the same type as > > > ordinary character literals (signed or unsigned dependent on target or use > > > of the -fsigned-char or -funsigned char options). > > OK in the absence of C++ maintainer objections within 72 hours. (This is > > the case where, when I added support for such literals for C (commit > > 7c5890cc0a0ecea0e88cc39e9fba6385fb579e61), I raised the question of > > whether they should be unsigned in the preprocessor for C++ as well.) > > Joseph, would you be so kind as to commit this patch series for me? I don't > have commit access. Thank you in advance! Done. -- Joseph S. Myers joseph@codesourcery.com