From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 8B2723858D32 for ; Tue, 23 Aug 2022 18:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B2723858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,258,1654588800"; d="scan'208";a="81879104" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 23 Aug 2022 10:23:27 -0800 IronPort-SDR: dVW9MroI/UTLfBF32lcBcKKAw1NJ45Zjltk9ZnAhZR7MlQnnmCt3lLeX7OSwybeTmJF3ssSkBs KmC1QHnZbFhfmHSs36vUs5lYcWu/6+QvW0n+hGauNgWZQJOtQDDHqcdICeL05MynX63EoyhlD2 1yCTDXAMR+L8RFRCuZolKzqwSRnuXwRs4Ec0RblK8ALcnW/cZ0QFShcPgpZxmbkBNj8rP71yCo sytN5RDGwFeLAv0HRQ9DrAFslGtql/2UTQEG+Fc29aAr3r1dBT0Q7TkopFexkFSjl2CcEEwO/j kQA= Date: Tue, 23 Aug 2022 18:23:23 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Jakub Jelinek CC: Subject: Re: Patch ping (Re: [PATCH] Implement __builtin_issignaling) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3111.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 18:23:32 -0000 On Tue, 23 Aug 2022, Jakub Jelinek via Gcc-patches wrote: > On Tue, Aug 16, 2022 at 11:41:06AM +0000, Richard Biener wrote: > > I'm OK with the rest of the patch if Joseph doesn't have comments > > on the actual issignaling lowerings (which I didn't review for > > correctness due to lack of knowledge). > > I'd like to ping this patch. > Patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599697.html > with > https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599794.html > https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599800.html > incremental additions. One testsuite comment: > +#ifdef __SIZEOF_FLOAT128__ > + if (f7 (w) || !f7 (__builtin_nansf128 ("0x123")) || f7 (42.0Q) || f7 (__builtin_nanf128 ("0x234")) > + || f7 (__builtin_inff128 ()) || f7 (-__builtin_inff128 ()) || f7 (-42.0Q) || f7 (-0.0Q) || f7 (0.0Q)) > + __builtin_abort (); __SIZEOF_FLOAT128__ is a target-specific macro for two targets. I think it's better to model things on the existing _FloatN and _FloatNx tests, so have such a test for each such type, preferably with most of the test implementation type-generic (see e.g. floatn-builtin.h) and then with the individual tests including e.g. /* { dg-add-options float128 } */ /* { dg-require-effective-target float128_runtime } */ to enable and test for the relevant support. That would mean _Float128 gets tested wherever supported - and also that the support is properly tested for _Float16, which doesn't look like it's covered by the tests in this patch at all at present. -- Joseph S. Myers joseph@codesourcery.com