From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <joseph_myers@mentor.com>
Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153])
	by sourceware.org (Postfix) with ESMTPS id 7D36D3858D39
	for <gcc-patches@gcc.gnu.org>; Wed, 31 Aug 2022 17:16:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D36D3858D39
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.93,278,1654588800"; 
   d="scan'208";a="85007763"
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])
  by esa1.mentor.iphmx.com with ESMTP; 31 Aug 2022 09:16:26 -0800
IronPort-SDR: e2Q8uYifCn+qHjVn/IN+ilbdyZPtVN9Ms9nL24TGp6nKnkbafiBwzTR7hpAGY8p8TOgdNbVhvi
 w7p8CZaQd7EzX+VuFLS1GGuE93cgLPnUEpsjo84E4HXs1puBRR52eGnntgCtMJAqaSuphvkuGR
 dvEDmDrL22ZJRJkHa88IPLncIlkH5QGoShEKUepHRq1YrFYFOZ3eKFSgEQXExMrYCQ4WER0JYT
 VQ3A4PHul1F/jsyly55k+mCPhp0hUvRTSj7lED5n0FmdmE5UHnPo9Cu+y8PTs552xAbmsWZzlo
 Q6Y=
Date: Wed, 31 Aug 2022 17:16:21 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Iain Buclaw <ibuclaw@gdcproject.org>
CC: Richard Biener <richard.guenther@gmail.com>, GCC Patches
	<gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] d: Fix #error You must define PREFERRED_DEBUGGING_TYPE
 if DWARF is not supported (PR105659)
In-Reply-To: <1661946124.o8swlumpp1.astroid@pulse.none>
Message-ID: <alpine.DEB.2.22.394.2208311715090.498823@digraph.polyomino.org.uk>
References: <20220816211627.209433-1-ibuclaw@gdcproject.org> <CAFiYyc2-nr=+1UFbtnqXzJov1fGvVjEmd5qi9hM0VVk8V_W3=g@mail.gmail.com> <alpine.DEB.2.22.394.2208302151520.446383@digraph.polyomino.org.uk> <1661946124.o8swlumpp1.astroid@pulse.none>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To
 svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10)
X-Spam-Status: No, score=-3111.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Wed, 31 Aug 2022, Iain Buclaw via Gcc-patches wrote:

> Excerpts from Joseph Myers's message of August 30, 2022 11:53 pm:
> > On Fri, 26 Aug 2022, Richard Biener via Gcc-patches wrote:
> > 
> >> I was hoping Joseph would chime in here - I recollect debugging this kind
> >> of thing and a thread about this a while back but unfortunately I do not
> >> remember the details here (IIRC some things get included where they
> >> better should not be).
> > 
> > See <https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582563.html>.  
> > Is there some reason it's problematic to avoid having defaults.h or 
> > ${cpu_type}/${cpu_type}.h included in tm_d.h, and instead have tm_d.h only 
> > include D-specific headers?
> > 
> 
> In targets such as arm-elf, we still need to pull in definitions from
> ${cpu_type}/${cpu_type}-d.cc into default-d.cc.
> 
> All I can think that might suffice is having D-specific prototype
> headers in all targets as ${cpu_type}/${cpu_type}-d.h.

As long as those prototypes don't involve any types that depend on an 
inclusion of tm.h, that should be fine.

-- 
Joseph S. Myers
joseph@codesourcery.com