From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 992003858D38 for ; Thu, 22 Sep 2022 22:42:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 992003858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,337,1654588800"; d="scan'208";a="86260709" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 22 Sep 2022 14:42:50 -0800 IronPort-SDR: gBQ7QWFb3qFLZktriNG9WfEpjYU6MixVLIlzR30YICXQiuvOweuj9E55bCAqXP8+Dr7QJ1+fb/ P103N6jUfpGuM1qq1AYNkbn5q2tK+nmO/4WE3yL5hCDGD09rzs4AtEldjbqXVfBB6ayPUvvgGO /AsepQo7pN62LK6QX/nWIsQFf2akkO7a+kYkzaXavv5SJUi6YgT5UK4RU0ppKGkLC3TSozsXq1 F2Ho1V5dV2FBooDryPu9cRDn4QSLGmd8qu9j/yI/SglXhduUEE2P0xaocvm3eIuerW17wWmHnK YGg= Date: Thu, 22 Sep 2022 22:42:46 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: =?ISO-8859-15?Q?Torbj=F6rn_SVENSSON?= CC: Subject: Re: [PATCH] testsuite: Sanitize fails for SP FPU on Arm In-Reply-To: <20220922164057.4107373-1-torbjorn.svensson@foss.st.com> Message-ID: References: <20220922164057.4107373-1-torbjorn.svensson@foss.st.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-1194220458-1663886566=:122140" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3111.1 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ---1152306461-1194220458-1663886566=:122140 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Thu, 22 Sep 2022, Torbjörn SVENSSON via Gcc-patches wrote: > This patch stops reporting fails for Arm targets with single > precision floating point unit for types wider than 32 bits (the width > of float on arm-none-eabi). > > As reported in PR102017, fenv is reported as supported in recent > versions of newlib. At the same time, for some Arm targets, the > implementation in libgcc does not support exceptions and thus, the > test fails with a call to abort(). It's definitely wrong to have this sort of Arm-specific conditional in architecture-independent tests. Tests requiring floating-point exceptions support should have an appropriate dg-require-effective-target; if that dg-require-effective-target wrongly passes in certain configurations, fix it (or e.g. add a new check_effective_target_fenv_exceptions_double to verify that exceptions work for double, as opposed to the present check_effective_target_fenv_exceptions which checks whether exceptions work for float, and then adjust tests requiring exceptions for double to use the new effective-target). -- Joseph S. Myers joseph@codesourcery.com ---1152306461-1194220458-1663886566=:122140--