From: Joseph Myers <joseph@codesourcery.com>
To: Lulu Cheng <chenglulu@loongson.cn>
Cc: <gcc-patches@gcc.gnu.org>, <mliska@suse.cz>, <xuchenghua@loongson.cn>
Subject: Re: [PATCH] LoongArch: Libitm add LoongArch support.
Date: Thu, 29 Sep 2022 16:31:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2209291629330.527883@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20220926020504.791159-1-chenglulu@loongson.cn>
On Mon, 26 Sep 2022, Lulu Cheng wrote:
> +GTM_longjmp:
> + cfi_startproc
> + GPR_L $s0, $r5, 3*SZ_GPR
> + GPR_L $s1, $r5, 4*SZ_GPR
> + GPR_L $s2, $r5, 5*SZ_GPR
> + GPR_L $s3, $r5, 6*SZ_GPR
> + GPR_L $s4, $r5, 7*SZ_GPR
> + GPR_L $s5, $r5, 8*SZ_GPR
> + GPR_L $s6, $r5, 9*SZ_GPR
> + GPR_L $s7, $r5, 10*SZ_GPR
> + GPR_L $s8, $r5, 11*SZ_GPR
> +
> + FPR_L $f24, $r5, 12*SZ_GPR + 0*SZ_FPR
> + FPR_L $f25, $r5, 12*SZ_GPR + 1*SZ_FPR
> + FPR_L $f26, $r5, 12*SZ_GPR + 2*SZ_FPR
> + FPR_L $f27, $r5, 12*SZ_GPR + 3*SZ_FPR
> + FPR_L $f28, $r5, 12*SZ_GPR + 4*SZ_FPR
> + FPR_L $f29, $r5, 12*SZ_GPR + 5*SZ_FPR
> + FPR_L $f30, $r5, 12*SZ_GPR + 6*SZ_FPR
> + FPR_L $f31, $r5, 12*SZ_GPR + 7*SZ_FPR
This is missing a __loongarch_soft_float conditional like the one present
above. Thus, this breaks building for soft-float:
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S: Assembler messages:
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:107: Error: no match insn: fpr_l $f24,$r5,12*8+0*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:108: Error: no match insn: fpr_l $f25,$r5,12*8+1*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:109: Error: no match insn: fpr_l $f26,$r5,12*8+2*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:110: Error: no match insn: fpr_l $f27,$r5,12*8+3*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:111: Error: no match insn: fpr_l $f28,$r5,12*8+4*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:112: Error: no match insn: fpr_l $f29,$r5,12*8+5*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:113: Error: no match insn: fpr_l $f30,$r5,12*8+6*0
/scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:114: Error: no match insn: fpr_l $f31,$r5,12*8+7*0
Makefile:657: recipe for target 'sjlj.lo' failed
https://sourceware.org/pipermail/libc-testresults/2022q3/010294.html
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2022-09-29 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 2:05 Lulu Cheng
2022-09-28 7:08 ` [commited PATCH] " Lulu Cheng
2022-09-29 16:31 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2209291629330.527883@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).