From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 163043858D39 for ; Thu, 29 Sep 2022 16:31:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 163043858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,355,1654588800"; d="scan'208";a="83855238" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 29 Sep 2022 08:31:20 -0800 IronPort-SDR: 7E3b72subYS1lQJqKlM2pmWx0ikO0WVYmRuW9OcilCqiGw9ap30TlRDNtV74qt5DxA5rD4TneP 1DJGW0oh1bkalQXIgeFSwOPljqUfFM0QHTQkOLtJmmd13Y0Ppoi4/y4v4VbYJxnIE7xntw19uo ASWg3JIve1CbeoTMCOE9MKf6zAOmMG4xub4tti2Iv3+7IfciMVaKOlT5M8Bej4FdqjH6ZIFYOM gLsua8fRtEw/+J+eMYuLsQ5L3+DiFg0acBHD7vh9VrYKqexpHHANhnDqg88HIt0YFm5o8l7+Ha x0g= Date: Thu, 29 Sep 2022 16:31:14 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Lulu Cheng CC: , , Subject: Re: [PATCH] LoongArch: Libitm add LoongArch support. In-Reply-To: <20220926020504.791159-1-chenglulu@loongson.cn> Message-ID: References: <20220926020504.791159-1-chenglulu@loongson.cn> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3111.0 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 26 Sep 2022, Lulu Cheng wrote: > +GTM_longjmp: > + cfi_startproc > + GPR_L $s0, $r5, 3*SZ_GPR > + GPR_L $s1, $r5, 4*SZ_GPR > + GPR_L $s2, $r5, 5*SZ_GPR > + GPR_L $s3, $r5, 6*SZ_GPR > + GPR_L $s4, $r5, 7*SZ_GPR > + GPR_L $s5, $r5, 8*SZ_GPR > + GPR_L $s6, $r5, 9*SZ_GPR > + GPR_L $s7, $r5, 10*SZ_GPR > + GPR_L $s8, $r5, 11*SZ_GPR > + > + FPR_L $f24, $r5, 12*SZ_GPR + 0*SZ_FPR > + FPR_L $f25, $r5, 12*SZ_GPR + 1*SZ_FPR > + FPR_L $f26, $r5, 12*SZ_GPR + 2*SZ_FPR > + FPR_L $f27, $r5, 12*SZ_GPR + 3*SZ_FPR > + FPR_L $f28, $r5, 12*SZ_GPR + 4*SZ_FPR > + FPR_L $f29, $r5, 12*SZ_GPR + 5*SZ_FPR > + FPR_L $f30, $r5, 12*SZ_GPR + 6*SZ_FPR > + FPR_L $f31, $r5, 12*SZ_GPR + 7*SZ_FPR This is missing a __loongarch_soft_float conditional like the one present above. Thus, this breaks building for soft-float: /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S: Assembler messages: /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:107: Error: no match insn: fpr_l $f24,$r5,12*8+0*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:108: Error: no match insn: fpr_l $f25,$r5,12*8+1*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:109: Error: no match insn: fpr_l $f26,$r5,12*8+2*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:110: Error: no match insn: fpr_l $f27,$r5,12*8+3*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:111: Error: no match insn: fpr_l $f28,$r5,12*8+4*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:112: Error: no match insn: fpr_l $f29,$r5,12*8+5*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:113: Error: no match insn: fpr_l $f30,$r5,12*8+6*0 /scratch/jmyers/glibc-bot/src/gcc/libitm/config/loongarch/sjlj.S:114: Error: no match insn: fpr_l $f31,$r5,12*8+7*0 Makefile:657: recipe for target 'sjlj.lo' failed https://sourceware.org/pipermail/libc-testresults/2022q3/010294.html -- Joseph S. Myers joseph@codesourcery.com