On Wed, 5 Oct 2022, Torbjörn SVENSSON via Gcc-patches wrote: > -/* These should be defined if and only if signaling NaNs are supported > - for the given types. If the testsuite gains effective-target > - support for targets not supporting signaling NaNs, or not > - supporting them for all types, this test should be made > - appropriately conditional. */ > +/* This should be defined if and only if signaling NaNs is supported > + for the given type. */ You've lost the point from the previous comment that the test should be made (further) conditional if the testsuite gains effective-target support for targets not supporting signaling NaNs. This patch deals with targets where exceptions are only supported for some types, but the test remains unportable to systems without sNaN support, and so the comment about that unportability should remain. -- Joseph S. Myers joseph@codesourcery.com