From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id BC09B3858CDB for ; Wed, 5 Oct 2022 20:15:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC09B3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,161,1661846400"; d="scan'208";a="84256674" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 05 Oct 2022 12:15:42 -0800 IronPort-SDR: dLgdXuV9aHhQloq7xX5SjvY9UsQPi9xd097DCBXZUFU+HOE8xaOJ40N/1Ngrf0BtdXwObRRkvM Bgm4hUklsrKDM7Ee1siY5ywQeSHkZn6waGxFiyXSXpErMFNrvCCUQ+HXBdG7D0otq4i2fuccgk V42DDEoCJBw/8smdd5ZzU+CX67MqBwXuQMNd365Er1qABCLwuYXOqZOHWxrVMdrsGB5XNCoPt6 ArnmbDpVfgUTdBT+LeWQ0gekHd6BfTyKHLuDaGmgv7SqrkkCqknBXzdhCzD7YM6+pYqaJ1OJJ4 Hy0= Date: Wed, 5 Oct 2022 20:15:37 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: =?ISO-8859-15?Q?Torbj=F6rn_SVENSSON?= CC: Subject: Re: [PATCH v2] testsuite: Sanitize fails for SP FPU on Arm In-Reply-To: <20221005145639.273140-1-torbjorn.svensson@foss.st.com> Message-ID: References: <20221005145639.273140-1-torbjorn.svensson@foss.st.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-1980726327-1665000937=:917581" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3110.8 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ---1152306461-1980726327-1665000937=:917581 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Wed, 5 Oct 2022, Torbjörn SVENSSON via Gcc-patches wrote: > -/* These should be defined if and only if signaling NaNs are supported > - for the given types. If the testsuite gains effective-target > - support for targets not supporting signaling NaNs, or not > - supporting them for all types, this test should be made > - appropriately conditional. */ > +/* This should be defined if and only if signaling NaNs is supported > + for the given type. */ You've lost the point from the previous comment that the test should be made (further) conditional if the testsuite gains effective-target support for targets not supporting signaling NaNs. This patch deals with targets where exceptions are only supported for some types, but the test remains unportable to systems without sNaN support, and so the comment about that unportability should remain. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-1980726327-1665000937=:917581--