From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id C63673858CDB for ; Wed, 5 Oct 2022 20:25:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C63673858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,161,1661846400"; d="scan'208";a="84257051" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 05 Oct 2022 12:25:15 -0800 IronPort-SDR: LTbb8OQ7lu0+40K4rZ/5Y2TKqarhVtXrt5GlOSWapHLj1DWeGShGoHO0xaw+yaVdeU0I0hz37I L6GLksv69tF1dDucb6x1rf6hW3eDGvBO+u90fAmlvS/05y4Ehynd7YbNzYQzswZI6fWlR820GB QHFUtEZxpFr94VIr1WQTbR2o/xbI537UDRZLmVwxUBW1/zrDo6XMxbEr7NPa2ZVgGPG3uUmUxm HR5Gwe0XWooROwj0hcbCokFexZwbN76WZxfZT+UKPK2cMYdE2/Uz5/Mb2NvfbuqcWH/uxcvyT2 pHM= Date: Wed, 5 Oct 2022 20:25:11 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Qing Zhao CC: , , , , Subject: Re: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array In-Reply-To: <20221005191320.2087486-2-qing.zhao@oracle.com> Message-ID: References: <20221005191320.2087486-1-qing.zhao@oracle.com> <20221005191320.2087486-2-qing.zhao@oracle.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3110.8 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 5 Oct 2022, Qing Zhao via Gcc-patches wrote: > + /* if not the last field, return false. */ Comments should start with an uppercase letter. > + /* if not an array field, return false. */ > + /* if there is a strict_flex_array attribute attached to the field, > + override the flag_strict_flex_arrays. */ > + /* get the value of the level first from the attribute. */ > + /* the attribute has higher priority than flag_struct_flex_array. */ > + /* default, all trailing arrays are flexiable array members. */ Likewise, and "flexible" not "flexiable". > + /* whether this field is the last field of the structure or union. > + for UNION, any field is the last field of it. */ Likewise. > +field of a structure as a flexible array member for the purposesof accessing Missing space, should be "purposes of". The C front-end and docs changes are OK with the fixes above. -- Joseph S. Myers joseph@codesourcery.com