From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126085 invoked by alias); 7 Feb 2020 14:28:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126076 invoked by uid 89); 7 Feb 2020 14:28:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=regtest X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2020 14:28:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581085696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65PLQfx/h8t0daCQOiGEwHYECOdYfagGIGWpnhRgHsw=; b=WqNDrjVxPdN2BHXhQbJgnh+5lmcwxbcA8dOB4myviQ/kaKEtRK4pqvH8U2lUhoGc0aLgbY RA91OwprEyXiRMbsq4MdZaplBVm6/SUGM3WaYBPIT3ZAMjW69bSa3jkk+ksZAsntqwZgU2 SFGfGzylc6RPsm5wSWBHDEK0gfDA4og= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417--8TFa_e6MnaWFFHn1QjggA-1; Fri, 07 Feb 2020 09:28:14 -0500 Received: by mail-qv1-f72.google.com with SMTP id g15so1234985qvk.11 for ; Fri, 07 Feb 2020 06:28:14 -0800 (PST) Return-Path: Received: from [192.168.1.130] (ool-457d493a.dyn.optonline.net. [69.125.73.58]) by smtp.gmail.com with ESMTPSA id s48sm1444174qtc.96.2020.02.07.06.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Feb 2020 06:28:13 -0800 (PST) From: Patrick Palka Date: Fri, 07 Feb 2020 14:28:00 -0000 To: Jonathan Wakely cc: Patrick Palka , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 3/3] libstdc++: Implement C++20 range adaptors In-Reply-To: <20200207114848.GP9441@redhat.com> Message-ID: References: <20200204020724.217468-1-ppalka@redhat.com> <20200204020724.217468-3-ppalka@redhat.com> <20200206172528.GB861768@redhat.com> <20200207114848.GP9441@redhat.com> User-Agent: Alpine 2.22 (DEB 395 2020-01-19) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00441.txt.bz2 On Fri, 7 Feb 2020, Jonathan Wakely wrote: > On 06/02/20 18:53 -0500, Patrick Palka wrote: > > On Thu, 6 Feb 2020, Jonathan Wakely wrote: > > > > +#ifdef __cpp_lib_threeway_comparison > > >=20 > > > This macro is mispelled, should be three_way with an underscore. > >=20 > > Oops! It looks like it's also mispelled in the definition of iota_view > > earlier in this file. >=20 > Oops, yes, my fault then. Fixed with this patch, tested > powerpc64le-linux and committed to master. I've reported the defect > with the return types to the LWG chair. >=20 > Your incremental changes look good, please squash them into the base > patch and push that to master. Thanks. Thanks for the review. I just committed the squashed version after a successful regtest.