From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35605 invoked by alias); 11 Feb 2020 21:31:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35596 invoked by uid 89); 11 Feb 2020 21:31:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=concluded, H*f:sk:8a502b4, H*MI:sk:8a502b4, H*i:sk:8a502b4 X-HELO: esa4.hgst.iphmx.com Received: from esa4.hgst.iphmx.com (HELO esa4.hgst.iphmx.com) (216.71.154.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 21:31:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1581456674; x=1612992674; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=0vR3CavbCn2gaftQNuZE1S3bkyB8t+DogKiJF1FYgfE=; b=P2Id60k4eYrAZeFuGgE52JreLmnniP/Y+rnOIHg/tkzMyHgwzQCWeCYa JCaaQ85gtFtZ2TJHpuctKGm/O4xCvLX3krpCaO+aVl/yOHKqj8US3xMsL YUXbf+XxcfBLy2EnEbsCOG5MJ+HxQ/K8I9bQ0rKu0F7Ifuv2BfNS1GtLQ iUgIqAroaf5+BlTY/A+Nb0YzocQSBTa0xhAiZVP+PATnx/ga05BTtgG7h i828t08YZ00vwO6GIKB9lgVHnI70LHzQoGR/urt5Urfiqeu/ZMW3KVqhl 07hKfOcysOpseFLnIkHT8D4ZWk16IXyLkhhsWqc0wzci9fGfnq57jhq4x Q==; IronPort-SDR: VcRFDbOrZsZ4dImGh5vxngeVO1lO+f3ORfb7yuNmZbTY+5M8pL18DrBS8Ja7BQemqR/C4S5GmX 8ogQSJCc3vRZlgxRaLEiTmtfDAS+6RjMmxWwPOqc4hVhUViEt5XoWT5bOY8ZhNWrg0pKooOB28 tuFHSGWHr9wrOw/YJXZ+8iMuwRzwvXTHF6vYnMuAG5FKQ+icX3c6BuWeRJffFBA4vhiWsAzxxd zJlGjZl3w5PMXOZQUyZa1tz+9zDUeUMwAWXFkJD2kCLezAZ3u/TAYy7GOp9IO8JAYRsEoNVa+g yHE= Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 12 Feb 2020 05:31:13 +0800 IronPort-SDR: 06Cgrfk5YwnjZhtYEgqif1aUKH9u5YCXf/roFv3WH1SnuUWdKkhqkXeW93vBQ7X7v7JFvPNn62 hV0JSKoeTzYNdO5+9XjU9F31YEKlYp6rbJuoWh2ZDnxMsmJQg7Uz/YloLPUi7G8qs8PkAccBuo byfyOkqmy6XP9JvV2tLN03ljdSqZuaCIDHbpLXercVGikbbXvG6BMeSTcAaWIzvjimZx5k2d15 /sX4OpkjfDJO0k8mwhGtOSC+CKOBh42DFXA0b99RRpaaSoJeU1z2mWPDv4oHhzh0wER1ROXwr3 ip4v0iaYFQ4XlxCUjSlr+Dzo Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 13:24:03 -0800 IronPort-SDR: Dw12wKdl+XS2mSE2CQ5SiqcuEzdUh1vru/A46SsFO2uGr4iiFsISdG7zlxZiWF5awr60snED0+ yfX7bEzS6bOtXkBtS5NcKcJsmZeGzwwYJu92iS1DsELzuWDAk5qVYWBWQBy0NL6nkoydOA616N fu7D6PyeM1HjYm6OFmhUvdn7FEn4Axj8pFWBBPLrZjzm/ssMS3jjaPhsHD8PZT162LQR+Z1/gF id2nvPRlttke/yN1uPWtHENhMcWBSCFkj2pAQSL8Og6+PZQUAJtOyDICvj4CCb5M4qAa0A0Jl7 LfE= WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 13:31:13 -0800 Date: Tue, 11 Feb 2020 21:31:00 -0000 From: "Maciej W. Rozycki" To: cltang@codesourcery.com cc: Julian Brown , Mike Stump , gcc-patches@gcc.gnu.org, Thomas Schwinge Subject: Re: [PING^4][PATCH 0/4] Fix library testsuite compilation for build sysroot In-Reply-To: <8a502b40-43d6-8e55-7fa6-1e4ed0f111f6@mentor.com> Message-ID: References: <6594B30D-743B-4B4C-81CE-11DD3EE87C8C@comcast.net> <20200103113421.51b55ff5@squid.athome> <8a502b40-43d6-8e55-7fa6-1e4ed0f111f6@mentor.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2020-02/txt/msg00678.txt.bz2 Hi Chung-Lin, > sorry for the late reply. No worries. > The 'AM_RUNTESTFLAGS = --tool_exec "$(CC)"' does work for us, but only because you backed out the change > from libgomp-test-support.exp, and our installed testing doesn't use the libgomp/testsuite/Makefile.* files > (we invoke runtest using another script). > > From the code in libgomp/testsuite/lib/libgomp.exp:libgomp_init(): > ... > if ![info exists GCC_UNDER_TEST] then { > if [info exists TOOL_EXECUTABLE] { > set GCC_UNDER_TEST $TOOL_EXECUTABLE > } else { > set GCC_UNDER_TEST "[find_gcc]" > } > } > > So essentially this patch is the same as the prior one, and still blocks the usual find_gcc logic from > ever getting control (as long as we use the in-tree 'make check'). I'm not sure that is the right > thing to do... That is intentional. The libgomp.exp test driver is generic and can be invoked standalone (e.g. with `contrib/test_installed'), in which case the user will decide with `runtest' options whether to use a compiler pointed at explicitly or to fall back to `[find_gcc]'. OTOH `make check' is tied to the build tree and I think it ought to use the same compiler, there's no point in using any compiler search logic. The only uncertainty was about libgomp-test-support.exp. Since it's generated I concluded it could be treated as tied to the build tree, however your use case has served as a counter example, so I have backed out my change as I have come up with a change that is equally good for my purpose and does not cause you and possibly other people trouble. > That said, I don't have anything further against this patch. Okay for me. Great, thanks for verifying my proposal. > (I do still think that actually detecting the right in-tree compiler and giving the correct sysroot > options from the configuration is the more proper approach, maybe later) Well, the in-tree compiler is $(CC), $(CXX), etc., as embedded in the Makefile structure, and I don't think you can guess it in DejaGNU without referring to those `make' variables. I'll post an updated series; it has passed my testing. Maciej