From: "Maciej W. Rozycki" <macro@wdc.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] configure: Re-disable building cross-gdbserver
Date: Thu, 13 Feb 2020 23:48:00 -0000 [thread overview]
Message-ID: <alpine.LFD.2.21.2002132343180.18621@redsun52.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <23ccb2bf-7e7a-3896-cc87-fd5398a158ca@redhat.com>
On Wed, 12 Feb 2020, Pedro Alves wrote:
> > That's actually quite similar to what I considered first, before I
> > changed my mind. Whatever.
>
> Doing it in gdbserver/ has the advantage that it stays under gdbserver's
> control, so it doesn't need syncing code with the gcc tree. I know of at
> least one off-tree port that uses gdbserver in a host != target scenario,
> so I imagine that this condition will evolve over time.
Sure, that makes sense to me.
> > case "${host}" in
> > + ${target})
> > + gdbserver_host=${host}
> > + ;;
> > + *)
> > + gdbserver_host=NONE
> > + ;;
> if/else reads more to-the-point to me, so I tweaked it that
> way, and merged it in (to binutils-gdb), like below.
Great, thanks for handling this!
> I'm sorry for not noticing your earlier patch.
No worries, I'm glad we've got this sorted.
Maciej
prev parent reply other threads:[~2020-02-13 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 16:21 Maciej W. Rozycki
2020-02-11 15:24 ` Tom Tromey
2020-02-11 21:02 ` Maciej W. Rozycki
2020-02-12 13:56 ` Pedro Alves
2020-02-13 23:48 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2002132343180.18621@redsun52.ssa.fujisawa.hgst.com \
--to=macro@wdc.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).