From: "Maciej W. Rozycki" <macro@wdc.com>
To: gcc-patches@gcc.gnu.org
Cc: Jeff Law <law@redhat.com>, Mike Stump <mikestump@comcast.net>,
Chung-Lin Tang <cltang@codesourcery.com>,
Ian Lance Taylor <iant@golang.org>
Subject: [PATCH v4 0/5] Fix library testsuite compilation for build sysroot
Date: Sat, 4 Apr 2020 00:00:20 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2004031338210.461@redsun52.ssa.fujisawa.hgst.com> (raw)
Hi,
This is v4 of patch series, originally posted here:
<https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00767.html>
<https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00768.html>
<https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00769.html>
<https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00770.html>
v2 posted here:
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00827.html>
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00828.html>
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00829.html>
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg00830.html>
and v3 posted here:
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01592.html>
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01593.html>
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01594.html>
<https://gcc.gnu.org/ml/gcc-patches/2020-02/msg01595.html>
meant to address a problem with the testsuite compiler being set up across
libatomic, libffi, libgo, libgomp with no correlation whatsoever to the
target compiler being used in GCC compilation. Consequently there in no
arrangement made to set up the compilation sysroot according to the build
sysroot specified for GCC compilation, causing a catastrophic failure
across the testsuites affected from the inability to link executables.
In the course of discussion it has been determined it might be the best
if we sync with libffi rather than providing our replacement solution, as
the upstream version has it addressed, although in a slightly messy way.
I have therefore decided to clean it up with upstream libffi and propose a
corresponding backport of the change to be included with our version.
This has resulted in two patches actually, replacing 2/4 from the original
series. The remaining changes are the same as in v3, however Chung-Lin
has since confirmed the libgomp change proposed here has addressed issues
with testing in his environment (thank you, Chung-Lin!).
Verified with a cross-compiler configured for the `riscv-linux-gnu'
target and the `x86_64-linux-gnu' host and using RISC-V/Linux QEMU in the
user emulation mode as the target board. Also no change in results with
`x86_64-linux-gnu' native regression testing.
See individual change descriptions for details.
I'm assuming Ian will take care of the 4/5 libgo change (Ian, it's up to
you if you want to have it or not).
Any objections about 1/5 previously approved by Jeff, and OK to apply 2/5
and 3/5 (if the corresponding changes have been accepted into upstream
libffi), as well as 5/5 to the GCC repo?
Maciej
next reply other threads:[~2020-04-03 23:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 23:00 Maciej W. Rozycki [this message]
2020-04-03 23:00 ` [PATCH v4 1/5] libatomic/test: Fix " Maciej W. Rozycki
2020-04-06 18:10 ` Jeff Law
2020-04-06 22:34 ` Maciej W. Rozycki
2023-09-12 11:03 ` libatomic: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951] (was: [PATCH v4 1/5] libatomic/test: Fix compilation for build sysroot) Thomas Schwinge
2023-10-25 8:32 ` [PING] " Thomas Schwinge
2023-10-26 13:34 ` [PING] libatomic: Consider '--with-build-sysroot=[...]' for target libraries' build-tree testing (instead of build-time 'CC' etc.) [PR109951] Jeff Law
2020-04-03 23:01 ` [PATCH v4 GCC 2/5] libffi/test: Fix compilation for build sysroot Maciej W. Rozycki
2020-04-06 18:06 ` Jeff Law
2020-04-06 20:21 ` Maciej W. Rozycki
2020-04-03 23:01 ` [PATCH v4 GCC 3/5] libffi/test: Make `libffi-init' use $CC_FOR_TARGET Maciej W. Rozycki
2020-04-03 23:01 ` [PATCH v4 4/5] libgo/test: Complement compilation fix for build sysroot Maciej W. Rozycki
2020-04-03 23:01 ` [PATCH v4 5/5] libgomp/test: Remove a build sysroot fix regression Maciej W. Rozycki
2020-04-06 18:11 ` Jeff Law
2020-04-06 22:34 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2004031338210.461@redsun52.ssa.fujisawa.hgst.com \
--to=macro@wdc.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
--cc=law@redhat.com \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).