From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cvs.linux-mips.org (eddie.linux-mips.org [148.251.95.138]) by sourceware.org (Postfix) with ESMTP id 6F5B3385802D for ; Mon, 30 Nov 2020 16:02:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F5B3385802D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-mips.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=macro@linux-mips.org Received: from localhost.localdomain ([127.0.0.1]:50358 "EHLO localhost" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992580AbgK3QCG15xCV (ORCPT ); Mon, 30 Nov 2020 17:02:06 +0100 Date: Mon, 30 Nov 2020 16:02:06 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Anders Magnusson , Paul Koning , Matt Thomas Subject: Re: [PATCH 25/31] VAX: Fix predicates for widening multiply and multiply-add insns In-Reply-To: <4b71df2a-f66d-c14a-7210-dace2e93ea4d@redhat.com> Message-ID: References: <4b71df2a-f66d-c14a-7210-dace2e93ea4d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 16:02:14 -0000 On Fri, 20 Nov 2020, Jeff Law wrote: > ps.  Yes, I skipped the insv/extv changes.  They're usually a rats nest > of special cases.  We'll come back to them. I've thought of actually reducing the number of patterns to the minimum possible by folding the existing ones together, and then getting the alternatives sorted by fine-grained constraints at reload. There is that complication caused by INSV machine instruction preserving condition codes (understandably), so keeping it together with alternative code sequences that do set the codes in a single RTL insn would cause trouble with getting a matching insn for the comparison elimination pass. Or so I think. As you say, we can sort it later. It's an optimisation only anyway, the VAX EXTV/EXTZV/INSV machine instructions are flexible enough to handle just about anything, except that reportedly at a slow pace, at least with some implementations (I'd have to review that NVAX manual for the details, but it's hefty 1022 pages). So at worst we could use those instructions in all cases. Maciej