From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cvs.linux-mips.org (eddie.linux-mips.org [148.251.95.138]) by sourceware.org (Postfix) with ESMTP id B8137387085D for ; Tue, 15 Dec 2020 18:38:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8137387085D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-mips.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=macro@linux-mips.org Received: from localhost.localdomain ([127.0.0.1]:47146 "EHLO localhost" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23995065AbgLOSiLAuVV6 (ORCPT ); Tue, 15 Dec 2020 19:38:11 +0100 Date: Tue, 15 Dec 2020 18:38:10 +0000 (GMT) From: "Maciej W. Rozycki" To: Paul Koning cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , GCC Patches Subject: Re: [PATCH 29/31] PDP11: Use `const_double_zero' to express double zero constant In-Reply-To: Message-ID: References: <4c18d30e-dc77-8d67-03db-c357498040ae@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 18:38:15 -0000 On Tue, 15 Dec 2020, Paul Koning wrote: > > I'm fairly sure this is due to the difference in TARGET_SUPPORTS_WIDE_INT > > with the VAX backend vs the PDP-11 one. I have an idea how this should be > > addressed and will be implementing it shortly. > > What's the difference? pdp11 does support wide int. The VAX backend, being old-fashioned, does not and therefore overloads the CONST_DOUBLE rtx for that purpose, making it possibly relevant here (it has turned out not after all: the cause is the use of named patterns for the CC-setting insns referred to by splitters, which the VAX backend does not have). NB there's been no rush to update the VAX backend for proper wide integer support, which will require some caution AFAICT. Anyway I have a fix now I am satisfied with and will be posting it shortly. I'll appreciate it if you verify it as I have no means beyond making sure that it builds. I'll cc you on the upcoming submission; a general maintainer will have to approve it though. Maciej