public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Jeff Law <law@redhat.com>, Paul Koning <paulkoning@comcast.net>,
	Richard Sandiford <richard.sandiford@arm.com>,
	gcc-patches@gcc.gnu.org
Subject: [PATCH 4/4] VAX: Remove a duplicate `cc' mode attribute
Date: Fri, 8 Jan 2021 01:51:13 +0000 (GMT)	[thread overview]
Message-ID: <alpine.LFD.2.21.2101080141150.1637534@eddie.linux-mips.org> (raw)
In-Reply-To: <alpine.LFD.2.21.2101072204040.1637534@eddie.linux-mips.org>

Remove the `cc' mode attribute that duplicates the implicitly defined 
`mode' attribute.  No change to semantics.

	gcc/
	* config/vax/vax.md (cc): Remove mode attribute.
	(subst_<cc>, subst_f<cc>): Rename to...
	(subst_<mode>, subst_f<VAXccnz:mode>): ... these respectively.
	(*cbranch<VAXint:mode>4_<VAXcc:mode>): Update for `cc' removal.
	(*cbranch<VAXfp:mode>4_<VAXccnz:mode>): Likewise.
	(*branch_<mode>, *branch_<mode>_reversed): Likewise.
---
 gcc/config/vax/vax.md |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

gcc-vax-cc-mode.diff
Index: gcc/gcc/config/vax/vax.md
===================================================================
--- gcc.orig/gcc/config/vax/vax.md
+++ gcc/gcc/config/vax/vax.md
@@ -58,7 +58,6 @@
 
 (define_mode_iterator VAXcc [CC CCN CCNZ CCZ])
 (define_mode_iterator VAXccnz [CCN CCNZ CCZ])
-(define_mode_attr cc [(CC "cc") (CCN "ccn") (CCNZ "ccnz") (CCZ "ccz")])
 
 (define_code_iterator any_extract [sign_extract zero_extract])
 
@@ -67,7 +66,7 @@
 (include "predicates.md")
 
 ;; Make instructions that set the N, N+Z, and Z condition codes respectively.
-(define_subst "subst_<cc>"
+(define_subst "subst_<mode>"
   [(set (match_operand 0 "")
 	(match_operand 1 ""))
    (clobber (reg:CC VAX_PSL_REGNUM))]
@@ -78,7 +77,7 @@
    (set (match_dup 0)
 	(match_dup 1))])
 
-(define_subst "subst_f<cc>"
+(define_subst "subst_f<VAXccnz:mode>"
   [(set (match_operand:VAXfp 0 "")
 	(match_operand:VAXfp 1 ""))
    (clobber (reg:CC VAX_PSL_REGNUM))]
@@ -2174,7 +2173,7 @@
 (define_insn_and_split "*cbranch<VAXint:mode>4_<VAXcc:mode>"
   [(set (pc)
 	(if_then_else
-	  (match_operator 0 "vax_<cc>_comparison_operator"
+	  (match_operator 0 "vax_<VAXcc:mode>_comparison_operator"
 			  [(match_operand:VAXint 1 "general_operand" "nrmT")
 			   (match_operand:VAXint 2 "general_operand" "nrmT")])
 	  (label_ref (match_operand 3 "" ""))
@@ -2206,7 +2205,7 @@
 (define_insn_and_split "*cbranch<VAXfp:mode>4_<VAXccnz:mode>"
   [(set (pc)
 	(if_then_else
-	  (match_operator 0 "vax_<cc>_comparison_operator"
+	  (match_operator 0 "vax_<VAXccnz:mode>_comparison_operator"
 			  [(match_operand:VAXfp 1 "general_operand" "gF")
 			   (match_operand:VAXfp 2 "general_operand" "gF")])
 	  (label_ref (match_operand 3 "" ""))
@@ -2226,7 +2225,7 @@
 
 (define_insn "*branch_<mode>"
   [(set (pc)
-	(if_then_else (match_operator 0 "vax_<cc>_comparison_operator"
+	(if_then_else (match_operator 0 "vax_<mode>_comparison_operator"
 				      [(reg:VAXcc VAX_PSL_REGNUM)
 				       (const_int 0)])
 		      (label_ref (match_operand 1 "" ""))
@@ -2237,7 +2236,7 @@
 ;; Recognize reversed jumps.
 (define_insn "*branch_<mode>_reversed"
   [(set (pc)
-	(if_then_else (match_operator 0 "vax_<cc>_comparison_operator"
+	(if_then_else (match_operator 0 "vax_<mode>_comparison_operator"
 				      [(reg:VAXcc VAX_PSL_REGNUM)
 				       (const_int 0)])
 		      (pc)

  parent reply	other threads:[~2021-01-08  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  1:50 [PATCH 0/4] Fixes for `const_double_zero' use + VAX iterator simplification Maciej W. Rozycki
2021-01-08  1:50 ` [PATCH 1/4] RTL: Update `const_double_zero' handling for mode and callable insns Maciej W. Rozycki
2021-01-08 20:11   ` Jeff Law
2021-01-08  1:50 ` [PATCH 2/4] PDP11: Use a mode with `const_double_zero' expressions Maciej W. Rozycki
2021-01-08 15:04   ` Paul Koning
2021-01-10 14:34     ` Maciej W. Rozycki
2021-01-08  1:50 ` [PATCH 3/4] VAX: " Maciej W. Rozycki
2021-01-08 20:11   ` Jeff Law
2021-01-08  1:51 ` Maciej W. Rozycki [this message]
2021-01-08 20:11   ` [PATCH 4/4] VAX: Remove a duplicate `cc' mode attribute Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.2101080141150.1637534@eddie.linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=paulkoning@comcast.net \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).