From: Richard Guenther <rguenther@suse.de>
To: Richard Henderson <rth@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>
Subject: Re: [PATCH] Merge from LTO: eh_personality changes
Date: Thu, 10 Sep 2009 14:37:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.0909101629330.28140@zhemvz.fhfr.qr> (raw)
In-Reply-To: <alpine.LNX.2.00.0909101506250.28140@zhemvz.fhfr.qr>
On Thu, 10 Sep 2009, Richard Guenther wrote:
> On Tue, 8 Sep 2009, Richard Henderson wrote:
>
> > On 09/08/2009 08:20 AM, Richard Guenther wrote:
> > > > Ok. I'll modify the patch to make this a true langhook and maybe move
> > > > the eh-personality also to a langhook called from eh lowering.
> > >
> > > The latter is difficult as C++ is playing some tricks with Java vs.
> > > non-Java personality, so I leave that alone for now.
> >
> > Ew.
> >
> > > FYI the following two patches would implement the above (untested).
> >
> > Looks good.
>
> I've been playing a bit with optimizing setting of
> DECL_FUNCTION_EH_PERSONALITY only if the function uses EH types
> instead of just checking for an empty EH region tree. It doesn't look
> like its very simple - even a catch (...) needs a personality routine.
>
> So I am now testing the following - the ERT_ALLOWED_EXCEPTIONS case
> is required to get diagnostics from g++.dg/torture/pr34850.C which
> requires inlining memset into clear_mem.
>
> If that doesn't work out I'll refrain from optimizing at all and
> just disable cross different EH personality TU inlining completely
> (that already passed bootstrapping and testing, it would be
> - if (function_needs_eh_personality (cfun))
> - DECL_FUNCTION_PERSONALITY (current_function_decl) =
> eh_personality_decl;
> + DECL_FUNCTION_PERSONALITY (current_function_decl) =
> eh_personality_decl;
> meaning no functional change as far as trunk is concerned)
Doesn't seem to work. Instead I tried to fall back to
the gcc personality for detecting empty type lists, again setting
a cfi personality for all functions we emit. But that doesn't work
either (it seems catch (...) doesn't work with the gcc personality,
g++.dg/eh/loop1.C fails).
Bah.
So, ok without trying to be clever about inlining cross personality
for now?
Thanks,
Richard.
next prev parent reply other threads:[~2009-09-10 14:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 13:34 Richard Guenther
2009-09-04 13:37 ` Diego Novillo
2009-09-04 13:41 ` Richard Guenther
2009-09-05 16:37 ` Richard Henderson
2009-09-05 16:38 ` Richard Henderson
2009-09-05 17:24 ` Richard Guenther
2009-09-05 18:11 ` Richard Henderson
2009-09-08 12:37 ` Richard Guenther
2009-09-08 15:20 ` Richard Guenther
2009-09-08 15:49 ` Richard Henderson
2009-09-10 13:12 ` Richard Guenther
2009-09-10 14:37 ` Richard Guenther [this message]
2009-09-10 14:52 ` Richard Guenther
2009-09-10 15:50 ` Richard Guenther
2009-09-10 15:57 ` Richard Henderson
2009-09-10 15:50 ` Richard Henderson
2009-09-10 16:02 ` Richard Guenther
2009-09-10 16:06 ` Richard Guenther
2009-09-10 16:23 ` Richard Henderson
2009-09-11 13:25 ` Richard Guenther
2009-09-11 15:41 ` Richard Henderson
2009-09-11 16:41 ` Richard Guenther
2009-09-11 17:05 ` Richard Henderson
2009-09-13 22:57 ` H.J. Lu
2010-12-29 5:30 ` H.J. Lu
2010-12-29 5:36 ` H.J. Lu
2011-02-08 2:06 ` H.J. Lu
2009-09-10 16:12 ` Richard Henderson
2009-09-08 17:38 ` Eric Botcazou
2009-09-08 15:48 ` Richard Henderson
2009-09-08 16:04 ` Richard Guenther
2009-09-09 9:34 ` Richard Guenther
2009-09-09 15:24 ` Richard Henderson
2009-09-09 15:26 ` Richard Guenther
2009-09-14 2:43 David Edelsohn
2009-09-14 5:38 ` Gerald Pfeifer
2009-09-14 9:37 ` Richard Guenther
2009-09-15 8:15 ` Gerald Pfeifer
2009-09-15 11:48 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.0909101629330.28140@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).