public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Guenther <rguenther@suse.de>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: Richard Guenther <richard.guenther@gmail.com>,
		Richard Henderson <rth@redhat.com>,
	gcc-patches@gcc.gnu.org, 	Diego Novillo <dnovillo@google.com>
Subject: Re: [PATCH] Merge from LTO: eh_personality changes
Date: Mon, 14 Sep 2009 09:37:00 -0000	[thread overview]
Message-ID: <alpine.LNX.2.00.0909141136430.4520@zhemvz.fhfr.qr> (raw)
In-Reply-To: <303e1d290909131942w621302b2m8433c4316b567809@mail.gmail.com>

On Sun, 13 Sep 2009, David Edelsohn wrote:

> This patch broke bootstrap on AIX:
> 
> /farm/dje/src/src/libstdc++-v3/libsupc++/eh_ptr.cc: In destructor
> 'std::__exception_ptr::exception_ptr::~exception_ptr()':
> /farm/dje/src/src/libstdc++-v3/libsupc++/eh_ptr.cc:67:1: sorry,
> unimplemented: Multiple EH personalities are supported only with
> assemblers supporting .cfi.personality directive.
> make[2]: *** [eh_ptr.lo] Error 1

Doh, I forgot about that path.  Fixed like the following, committed
as obvious.  Can you verify this restores bootstrap?

Thanks,
Richard.

2009-09-14  Richard Guenther  <rguenther@suse.de>

	PR middle-end/41350
	* dwarf2out.c (dwarf2out_begin_prologue): Adjust non-CFI asm
	EH personality path.

	* g++.dg/debug/dwarf-eh-personality-1.C: New testcase.

Index: gcc/dwarf2out.c
===================================================================
*** gcc/dwarf2out.c	(revision 151680)
--- gcc/dwarf2out.c	(working copy)
*************** dwarf2out_begin_prologue (unsigned int l
*** 3881,3887 ****
    char label[MAX_ARTIFICIAL_LABEL_BYTES];
    char * dup_label;
    dw_fde_ref fde;
-   rtx personality;
    section *fnsec;
  
    current_function_func_begin_label = NULL;
--- 3881,3886 ----
*************** dwarf2out_begin_prologue (unsigned int l
*** 3976,3989 ****
      dwarf2out_source_line (line, file, 0, true);
  #endif
  
-   personality = get_personality_function (current_function_decl);
    if (dwarf2out_do_cfi_asm ())
      dwarf2out_do_cfi_startproc (false);
    else
      {
!       if (!current_unit_personality || current_unit_personality == personality)
          current_unit_personality = personality;
!       else
  	sorry ("Multiple EH personalities are supported only with assemblers "
  	       "supporting .cfi.personality directive.");
      }
--- 3975,3993 ----
      dwarf2out_source_line (line, file, 0, true);
  #endif
  
    if (dwarf2out_do_cfi_asm ())
      dwarf2out_do_cfi_startproc (false);
    else
      {
!       rtx personality = get_personality_function (current_function_decl);
!       if (!current_unit_personality)
          current_unit_personality = personality;
! 
!       /* We cannot keep a current personality per function as without CFI
! 	 asm at the point where we emit the CFI data there is no current
! 	 function anymore.  */
!       if (personality
! 	  && current_unit_personality != personality)
  	sorry ("Multiple EH personalities are supported only with assemblers "
  	       "supporting .cfi.personality directive.");
      }
Index: gcc/testsuite/g++.dg/debug/dwarf-eh-personality-1.C
===================================================================
*** gcc/testsuite/g++.dg/debug/dwarf-eh-personality-1.C	(revision 0)
--- gcc/testsuite/g++.dg/debug/dwarf-eh-personality-1.C	(revision 0)
***************
*** 0 ****
--- 1,17 ----
+ // { dg-options "-fno-dwarf2-cfi-asm" }
+ 
+ extern void bar (void);
+ int foo (void)
+ {
+   try {
+       bar();
+   } catch (...) {
+       return 1;
+   }
+   return 0;
+ }
+ 
+ int foobar (void)
+ {
+ }
+ 

  parent reply	other threads:[~2009-09-14  9:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14  2:43 David Edelsohn
2009-09-14  5:38 ` Gerald Pfeifer
2009-09-14  9:37 ` Richard Guenther [this message]
2009-09-15  8:15   ` Gerald Pfeifer
2009-09-15 11:48     ` David Edelsohn
  -- strict thread matches above, loose matches on Subject: below --
2009-09-04 13:34 Richard Guenther
2009-09-04 13:37 ` Diego Novillo
2009-09-04 13:41   ` Richard Guenther
2009-09-05 16:37 ` Richard Henderson
2009-09-05 16:38 ` Richard Henderson
2009-09-05 17:24   ` Richard Guenther
2009-09-05 18:11     ` Richard Henderson
2009-09-08 12:37       ` Richard Guenther
2009-09-08 15:20         ` Richard Guenther
2009-09-08 15:49           ` Richard Henderson
2009-09-10 13:12             ` Richard Guenther
2009-09-10 14:37               ` Richard Guenther
2009-09-10 14:52                 ` Richard Guenther
2009-09-10 15:50                   ` Richard Henderson
2009-09-10 16:02                     ` Richard Guenther
2009-09-10 16:06                       ` Richard Guenther
2009-09-10 16:23                         ` Richard Henderson
2009-09-11 13:25                           ` Richard Guenther
2009-09-11 15:41                             ` Richard Henderson
2009-09-11 16:41                               ` Richard Guenther
2009-09-11 17:05                                 ` Richard Henderson
2009-09-13 22:57                                 ` H.J. Lu
2010-12-29  5:30                                   ` H.J. Lu
2010-12-29  5:36                                     ` H.J. Lu
2011-02-08  2:06                                       ` H.J. Lu
2009-09-10 16:12                       ` Richard Henderson
2009-09-10 15:50                   ` Richard Guenther
2009-09-10 15:57                     ` Richard Henderson
2009-09-08 17:38           ` Eric Botcazou
2009-09-08 15:48         ` Richard Henderson
2009-09-08 16:04           ` Richard Guenther
2009-09-09  9:34             ` Richard Guenther
2009-09-09 15:24               ` Richard Henderson
2009-09-09 15:26                 ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.0909141136430.4520@zhemvz.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=dje.gcc@gmail.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).