From: Richard Guenther <rguenther@suse.de>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org, Martin Jambor <mjambor@suse.de>,
Diego Novillo <dnovillo@google.com>
Subject: Re: LTO/WHOPR summary streaming fixes
Date: Tue, 20 Oct 2009 15:17:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.0910201711570.4520@zhemvz.fhfr.qr> (raw)
In-Reply-To: <alpine.LNX.2.00.0910201700560.4520@zhemvz.fhfr.qr>
On Tue, 20 Oct 2009, Richard Guenther wrote:
> On Tue, 20 Oct 2009, Jan Hubicka wrote:
>
> > Hi,
> > this patch fixes summary generation issues with LTO and WHOPR. The main changes are:
> >
> > 1) We used to re-compute all summaries at LTO read in. This is not correct, we should
> > use what we wrote into disk.
> > 2) We used to write summaries into ltrans files and re-execute all IPA passes. This is
> > wrong since all decisions should've been mae at WPA
> > 3) Jump functions are not streamed out.
> > Note that I did not include patch to stream in/out indirect call notes. This is not
> > needed for testsuite so I want to handle this independently.
> > 4) ipa-reference was saving summaries only for overwrittable functions.
> >
> > Note that whopr is still somewhat broken. We now apply the inline plan
> > changes, but other passes are not run and we now lose some optimization by
> > not re-doing all IPA passes at ltrans stage. I have incremental patches for this,
> > I am just trying to avoid snowballing effect.
> >
> > I've bootstrapped/regtested earlier vesion of this patch on x86_64-linux and I
> > am re-testing current version. I think I can approve myself all changes except
> > for the streaming part. OK?
>
> It looks good to me. Let me build a piece of SPEC2006 with the patch,
> I'll report on IRC before I leave today.
Even trivial files now ICE with
alloca.c:202:1: internal compiler error: in ipa_write_node_info, at
ipa-prop.c:1977
Richard.
next prev parent reply other threads:[~2009-10-20 15:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 15:01 Jan Hubicka
2009-10-20 15:05 ` Richard Guenther
2009-10-20 15:17 ` Richard Guenther [this message]
2009-10-20 15:22 ` Richard Guenther
2009-10-20 21:28 ` Jan Hubicka
2009-10-21 17:55 ` Jan Hubicka
2009-10-21 19:42 ` Richard Guenther
2009-10-21 20:07 ` Jan Hubicka
2009-10-21 21:24 ` Jan Hubicka
2009-10-22 2:53 ` Jan Hubicka
2009-10-22 8:55 ` Richard Guenther
2009-10-22 10:27 ` Richard Guenther
2009-10-22 12:52 ` Richard Guenther
2009-10-22 13:02 ` Jan Hubicka
2009-10-26 20:22 ` Martin Jambor
2009-10-26 22:30 ` Jan Hubicka
2009-10-20 15:06 ` Diego Novillo
2009-10-20 15:10 ` Jan Hubicka
2009-10-20 15:12 ` Diego Novillo
2009-10-20 16:18 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.0910201711570.4520@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mjambor@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).