Re: LTO/WHOPR summary streaming fixes

[Richard Guenther <rguenther@suse.de>]

On Tue, 20 Oct 2009, Richard Guenther wrote:

> On Tue, 20 Oct 2009, Richard Guenther wrote:
> 
> > On Tue, 20 Oct 2009, Jan Hubicka wrote:
> > 
> > > Hi,
> > > this patch fixes summary generation issues with LTO and WHOPR.  The main changes are:
> > > 
> > >   1) We used to re-compute all summaries at LTO read in.  This is not correct, we should
> > >      use what we wrote into disk.
> > >   2) We used to write summaries into ltrans files and re-execute all IPA passes.  This is
> > >      wrong since all decisions should've been mae at WPA
> > >   3) Jump functions are not streamed out.
> > >      Note that I did not include patch to stream in/out indirect call notes.  This is not
> > >      needed for testsuite so I want to handle this independently.
> > >   4) ipa-reference was saving summaries only for overwrittable functions.
> > > 
> > > Note that whopr is still somewhat broken.  We now apply the inline plan
> > > changes, but other passes are not run and we now lose some optimization by
> > > not re-doing all IPA passes at ltrans stage.  I have incremental patches for this,
> > > I am just trying to avoid snowballing effect.
> > > 
> > > I've bootstrapped/regtested earlier vesion of this patch on x86_64-linux and I
> > > am re-testing current version.  I think I can approve myself all changes except
> > > for the streaming part.  OK?
> > 
> > It looks good to me.  Let me build a piece of SPEC2006 with the patch,
> > I'll report on IRC before I leave today.
> 
> Even trivial files now ICE with
> 
> alloca.c:202:1: internal compiler error: in ipa_write_node_info, at 
> ipa-prop.c:1977

typedef long unsigned int size_t;
static int stack_dir;
static void find_stack_direction () {
    static char *addr = ((void *)0);
    auto char dummy;
    if (addr == ((void *)0))     {
        addr = &(dummy);
        find_stack_direction ();
    }
}
void * C_alloca (size)      size_t size;
{
  if (stack_dir == 0)     find_stack_direction ();
}

> /space/rguenther/install/lto/bin/gcc -c -O2 -flto  alloca.3.i
alloca.3.i:14:1: internal compiler error: in ipa_write_node_info, at 
ipa-prop.c:1977
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.