From: Richard Guenther <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>,
Jie Zhang <jie@codesourcery.com>,
Alexandre Oliva <aoliva@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Do framep replacement even on RHS outside of MEM contexts (PR debug/44694 followup)
Date: Thu, 01 Jul 2010 11:07:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.1007011306530.1429@zhemvz.fhfr.qr> (raw)
In-Reply-To: <20100701110645.GU25077@tyan-ft48-01.lab.bos.redhat.com>
On Thu, 1 Jul 2010, Jakub Jelinek wrote:
> On Thu, Jul 01, 2010 at 10:22:05AM +0200, Jakub Jelinek wrote:
> > On Thu, Jul 01, 2010 at 04:13:03PM +0800, Jie Zhang wrote:
> > > This patch caused ICE for arm-none-eabi target:
> > >
> > > internal compiler error: in arm_dbx_register_number, at
> > > config/arm/arm.c:21155
> > >
> > > when compiling thumb multilib libstdc++.
> >
> > Richard Earnshaw has already reported this in the PR, and here is my fix for
> > that. I don't have any arm boxes, so will just test it on x86_64-linux and
> > i686-linux (the PR44694 patch has been tested also on ppc/ppc64/s390/s390x
> > btw), could you please test it on arm? Thanks.
> >
> > 2010-07-01 Jakub Jelinek <jakub@redhat.com>
> >
> > PR debug/44694
> > * dwarf2out.c (reg_loc_descriptor): For eliminated arg_pointer_rtx
> > or frame_pointer_rtx use DW_OP_fbreg offset DW_OP_stack_value.
>
> Now bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk/4.5?
Ok.
Thanks,
Richard.
> > --- gcc/dwarf2out.c.jj 2010-07-01 08:45:55.000000000 +0200
> > +++ gcc/dwarf2out.c 2010-07-01 09:19:47.000000000 +0200
> > @@ -12999,6 +12999,26 @@ reg_loc_descriptor (rtx rtl, enum var_in
> > if (REGNO (rtl) >= FIRST_PSEUDO_REGISTER)
> > return 0;
> >
> > + /* We only use "frame base" when we're sure we're talking about the
> > + post-prologue local stack frame. We do this by *not* running
> > + register elimination until this point, and recognizing the special
> > + argument pointer and soft frame pointer rtx's.
> > + Use DW_OP_fbreg offset DW_OP_stack_value in this case. */
> > + if ((rtl == arg_pointer_rtx || rtl == frame_pointer_rtx)
> > + && eliminate_regs (rtl, VOIDmode, NULL_RTX) != rtl)
> > + {
> > + dw_loc_descr_ref result = NULL;
> > +
> > + if (dwarf_version >= 4 || !dwarf_strict)
> > + {
> > + result = mem_loc_descriptor (rtl, VOIDmode, initialized);
> > + if (result)
> > + add_loc_descr (&result,
> > + new_loc_descr (DW_OP_stack_value, 0, 0));
> > + }
> > + return result;
> > + }
> > +
> > regs = targetm.dwarf_register_span (rtl);
> >
> > if (hard_regno_nregs[REGNO (rtl)][GET_MODE (rtl)] > 1 || regs)
> >
>
> Jakub
>
>
--
Richard Guenther <rguenther@suse.de>
Novell / SUSE Labs
SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex
prev parent reply other threads:[~2010-07-01 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 15:29 [PATCH] Do framep replacement even on RHS outside of MEM contexts (PR debug/44694) Jakub Jelinek
2010-06-29 15:46 ` Richard Guenther
2010-06-29 16:03 ` Jakub Jelinek
2010-07-01 8:13 ` Jie Zhang
2010-07-01 8:21 ` Jakub Jelinek
2010-07-01 8:34 ` Jie Zhang
2010-07-01 11:06 ` [PATCH] Do framep replacement even on RHS outside of MEM contexts (PR debug/44694 followup) Jakub Jelinek
2010-07-01 11:07 ` Richard Guenther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1007011306530.1429@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=jie@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).