From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 842 invoked by alias); 28 Jan 2011 19:33:07 -0000 Received: (qmail 834 invoked by uid 22791); 28 Jan 2011 19:33:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL,TW_SV X-Spam-Check-By: sourceware.org Received: from relay02.pair.com (HELO relay02.pair.com) (209.68.5.16) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 28 Jan 2011 19:33:02 +0000 Received: (qmail 69631 invoked from network); 28 Jan 2011 19:32:58 -0000 Received: from 109.41.148.133 (HELO ip-109-41-148-133.web.vodafone.de) (109.41.148.133) by relay02.pair.com with SMTP; 28 Jan 2011 19:32:58 -0000 X-pair-Authenticated: 109.41.148.133 Date: Fri, 28 Jan 2011 20:01:00 -0000 From: Gerald Pfeifer To: "Joseph S. Myers" cc: Gary Funck , Gcc Patches Subject: Re: gcc_release script, snapshots, and LAST_UPDATED version In-Reply-To: Message-ID: References: <20101220014438.GI24726@intrepid.com> <20101220160327.GX24726@intrepid.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-01/txt/msg02145.txt.bz2 On Mon, 20 Dec 2010, Joseph S. Myers wrote: >>> It's LAST_UPDATED, not LAST_CHANGED. This is significant; the >>> revision number is indeed the revision at which the source tree was >>> last updated, not the revision at which the branch was last changed. >> OK. How is LAST_UPDATED more useful than LAST_CHANGED? I would have >> thought that it would be useful to know the last version on the branch >> that is being snap-shotted. > I think you should be doing your own interrogation of SVN information in > your snapshot script. This file is for convenient identification of > checkouts for the use of scripts such as contrib/test_summary; the > information it contains is already formally redundant (both revision and > date, in different time zones). I'm afraid you lost me here. Given the example Gary used svn info -r167957 file:///svn/gcc/branches/gcc-4_5-branch Path: gcc-4_5-branch URL: file:///svn/gcc/branches/gcc-4_5-branch Repository Root: file:///svn/gcc Repository UUID: 138bc75d-0d04-0410-961f-82ee72b054a4 Revision: 167957 Node Kind: directory Last Changed Author: rguenth Last Changed Rev: 167948 Last Changed Date: 2010-12-16 06:34:03 -0800 (Thu, 16 Dec 2010) why do we want to use Revision: and not Last Changed Rev: to describe the branch and accordingly make the following change to gcc_snapshot? - SVNREV=`${SVN} info "${SVNROOT}/${SVNBRANCH}"|awk '/Revision:/ {print$2}'` + SVNREV=`${SVN} info "${SVNROOT}/${SVNBRANCH}"|awk '/^Last Changed Rev:/ {print $4}'` > It is not meant to contain everything that could possibly be of use in > describing a checkout, and certainly not everything relevant for making > a snapshot decision (for normal GCC snapshots, you might want to skip > them if only the DATESTAMP file - checked in - had been updated since > the last snapshot). Isn't that backwards? Should we not simply avoid updating DATESTAMP if there have not been any changes since it's last update? I'd love to improve this, just right now I'm simply a bit confused, so any help, clarity or patches would be great. Gerald