From: Alexander Monakov <amonakov@ispras.ru>
To: Vladimir Makarov <vmakarov@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [committed] sel-sched: Fixup adding of preheader blocks from inner loops
Date: Fri, 08 Apr 2011 14:22:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.1104081811070.17990@monoid.intra.ispras.ru> (raw)
In-Reply-To: <4D9E1BA0.7020602@redhat.com>
I failed to notice that current_loop_nest is modified in
setup_current_loop_nest and used in sel_setup_region_sched_flags. Therefore,
sel_setup_region_sched_flags should be moved with setup_current_loop_nest
after sel_init_bbs as well.
I've committed the following patch under the 'obvious' rule after noticing the
problem on ia64 bootstrap with selective scheduler enabled at -O2 (I normally
do this together with amd64 bootstraps before committing patches, but this
time I made a typo that completely disabled sel-sched for ia64 testing).
Sorry for the noise.
2011-04-08 Alexander Monakov <amonakov@ispras.ru>
* sel-sched.c (sel_region_init): Move call to
sel_setup_region_sched_flags after setup_current_loop_nest.
Index: gcc/sel-sched.c
===================================================================
--- gcc/sel-sched.c (revision 172177)
+++ gcc/sel-sched.c (working copy)
@@ -6868,8 +6868,6 @@ sel_region_init (int rgn)
if (current_region_empty_p ())
return true;
- sel_setup_region_sched_flags ();
-
bbs = VEC_alloc (basic_block, heap, current_nr_blocks);
for (i = 0; i < current_nr_blocks; i++)
@@ -6880,6 +6878,8 @@ sel_region_init (int rgn)
if (flag_sel_sched_pipelining)
setup_current_loop_nest (rgn, &bbs);
+ sel_setup_region_sched_flags ();
+
/* Initialize luids and dependence analysis which both sel-sched and haifa
need. */
sched_init_luids (bbs, NULL, NULL, NULL);
prev parent reply other threads:[~2011-04-08 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 17:34 [PATCH] sel-sched: Fix adding of preheader blocks from inner loops (PR48302) Alexander Monakov
2011-04-07 20:16 ` Vladimir Makarov
2011-04-08 14:22 ` Alexander Monakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1104081811070.17990@monoid.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).