[Ping][Patch, testsuite]: Don't xfail sibcalls on AVR

[Ping][Patch, testsuite]: Don't xfail sibcalls on AVR

[Georg-Johann Lay]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Target avr now supports tail calls, so don't xfail on that.

testsuite/

2011-03-29  Georg-Johann Lay  <avr@gjlay.de>

	* gcc.dg/sibcall-3.c: Don't xfail on AVR.
	* gcc.dg/sibcall-4.c: Don't xfail on AVR.


[-- Attachment #2: testsuite.diff --]
[-- Type: text/x-patch, Size: 1853 bytes --]

Index: testsuite/gcc.dg/sibcall-3.c
===================================================================
--- testsuite/gcc.dg/sibcall-3.c	(Revision 171039)
+++ testsuite/gcc.dg/sibcall-3.c	(Arbeitskopie)
@@ -5,7 +5,7 @@
    Copyright (C) 2002 Free Software Foundation Inc.
    Contributed by Hans-Peter Nilsson  <hp@bitrange.com>  */
 
-/* { dg-do run { xfail { { arc-*-* avr-*-* cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* m68hc1?-*-* mcore-*-* mn10300-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */
+/* { dg-do run { xfail { { arc-*-* cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* m68hc1?-*-* mcore-*-* mn10300-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */
 /* -mlongcall disables sibcall patterns.  */
 /* { dg-skip-if "" { powerpc*-*-* } { "-mlongcall" } { "" } } */
 /* { dg-options "-O2 -foptimize-sibling-calls" } */
Index: testsuite/gcc.dg/sibcall-4.c
===================================================================
--- testsuite/gcc.dg/sibcall-4.c	(Revision 171039)
+++ testsuite/gcc.dg/sibcall-4.c	(Arbeitskopie)
@@ -5,7 +5,7 @@
    Copyright (C) 2002 Free Software Foundation Inc.
    Contributed by Hans-Peter Nilsson  <hp@bitrange.com>  */
 
-/* { dg-do run { xfail { { arc-*-* avr-*-* cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* m68hc1?-*-* mcore-*-* mn10300-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */
+/* { dg-do run { xfail { { arc-*-* cris-*-* crisv32-*-* h8300-*-* hppa*64*-*-* m32r-*-* m68hc1?-*-* mcore-*-* mn10300-*-* xstormy16-*-* v850*-*-* vax-*-* xtensa*-*-* } || { arm*-*-* && { ! arm32 } } } } } */
 /* -mlongcall disables sibcall patterns.  */
 /* { dg-skip-if "" { powerpc*-*-* } { "-mlongcall" } { "" } } */
 /* { dg-options "-O2 -foptimize-sibling-calls" } */

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Georg-Johann Lay]

Georg-Johann Lay schrieb:
> Target avr now supports tail calls, so don't xfail on that.
> 
> testsuite/
> 
> 2011-03-29  Georg-Johann Lay  <avr@gjlay.de>
> 
> 	* gcc.dg/sibcall-3.c: Don't xfail on AVR.
> 	* gcc.dg/sibcall-4.c: Don't xfail on AVR.
> 
> 

RE: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Weddington, Eric]

> -----Original Message-----
> From: Georg-Johann Lay [mailto:avr@gjlay.de]
> Sent: Tuesday, April 05, 2011 3:06 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Anatoly Sokolov; Denis Chertykov; Weddington, Eric
> Subject: Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR
> 
> Georg-Johann Lay schrieb:
> > Target avr now supports tail calls, so don't xfail on that.
> >
> > testsuite/
> >
> > 2011-03-29  Georg-Johann Lay  <avr@gjlay.de>
> >
> > 	* gcc.dg/sibcall-3.c: Don't xfail on AVR.
> > 	* gcc.dg/sibcall-4.c: Don't xfail on AVR.
> >
> >

Please commit, Johann. Thanks.

Eric

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Georg-Johann Lay]

Weddington, Eric schrieb:
> 
>> -----Original Message-----
>> From: Georg-Johann Lay [mailto:avr@gjlay.de]
>> Sent: Tuesday, April 05, 2011 3:06 AM
>> To: gcc-patches@gcc.gnu.org
>> Cc: Anatoly Sokolov; Denis Chertykov; Weddington, Eric
>> Subject: Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR
>>
>> Georg-Johann Lay schrieb:
>>> Target avr now supports tail calls, so don't xfail on that.
>>>
>>> testsuite/
>>>
>>> 2011-03-29  Georg-Johann Lay  <avr@gjlay.de>
>>>
>>> 	* gcc.dg/sibcall-3.c: Don't xfail on AVR.
>>> 	* gcc.dg/sibcall-4.c: Don't xfail on AVR.
>>>
> 
> Please commit, Johann. Thanks.
> 
> Eric

I don't have write privilege, and I don't think I want write access at
the moment.

Johann

RE: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Weddington, Eric]

> -----Original Message-----
> From: Georg-Johann Lay [mailto:avr@gjlay.de]
> Sent: Wednesday, April 06, 2011 4:55 AM
> To: Weddington, Eric
> Cc: gcc-patches@gcc.gnu.org; Anatoly Sokolov; Denis Chertykov
> Subject: Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR
> 
> >>> Target avr now supports tail calls, so don't xfail on that.
> >>>
> >>> testsuite/
> >>>
> >>> 2011-03-29  Georg-Johann Lay  <avr@gjlay.de>
> >>>
> >>> 	* gcc.dg/sibcall-3.c: Don't xfail on AVR.
> >>> 	* gcc.dg/sibcall-4.c: Don't xfail on AVR.
> >>>
> >
> > Please commit, Johann. Thanks.
> >
> > Eric
> 
> I don't have write privilege, and I don't think I want write access at
> the moment.

Oh! I didn't know. I thought you did.

Ok, let's see what I can do, then.

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Georg-Johann Lay]

Weddington, Eric schrieb:
> 
>> -----Original Message-----
>> From: Georg-Johann Lay [mailto:avr@gjlay.de]
>> To: Weddington, Eric

>>> Please commit, Johann. Thanks.
>>>
>> I don't have write privilege, and I don't think I want write access at
>> the moment.
> 
> Oh! I didn't know. I thought you did.

I signed a fsf copyright assignment. AFAIK there is no automatism that
grants write access when copyright assignment is approved. I would
have to be maintainer or something like that.

Johann

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Gerald Pfeifer]

On Wed, 6 Apr 2011, Georg-Johann Lay wrote:
> I signed a fsf copyright assignment. AFAIK there is no automatism
> that grants write access when copyright assignment is approved.

Yes, this is correct.

> I would have to be maintainer or something like that.

Nope.  All you need is a maintainer (Eric, Denis and Anatoly all
qualifying) to sponsor your request.  Obviously that mostly makes
sense if you expect to contribute more than a handfull of patches
over the course of the next year, which we do hope will be the
case. :-)

Gerald

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Georg-Johann Lay]

Gerald Pfeifer schrieb:
> On Wed, 6 Apr 2011, Georg-Johann Lay wrote:
>> I signed a fsf copyright assignment. AFAIK there is no automatism
>> that grants write access when copyright assignment is approved.
> 
> Yes, this is correct.
> 
>> I would have to be maintainer or something like that.
> 
> Nope.  All you need is a maintainer (Eric, Denis and Anatoly all
> qualifying) to sponsor your request.  Obviously that mostly makes
> sense if you expect to contribute more than a handfull of patches
> over the course of the next year, which we do hope will be the
> case. :-)
> 
> Gerald

Thanks for that hint. Is that the "Write after Approval" section in
MAINTAINERS?

Having write permissions would make thinks easier, both for the
maintainers and for me, I think.

However, I have bunch of questions for that I don't find answers in
the wiki. As it is very easy *not* to find something in the gcc wiki,
I probably just missed it...

1) What is the exact procedure for this? Will it be like fsf copyright
   assignment and take more than a year (at least in my case) to pass?

2) Changelogs and svn logs are always in sync. Is there some setup
   in the svn server to do this magic? Are there custom scripts for
   this or is it all hand-made?

3) Ditto for PRs that get a notification as soon as a patch goes
   upstream.

4) Will there be someone like a mentor who I could ask such
   questions or get useful hints?

Johann

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Ralf Wildenhues]

* Georg-Johann Lay wrote on Fri, Apr 08, 2011 at 11:30:29AM CEST:
> Gerald Pfeifer schrieb:
> > Nope.  All you need is a maintainer (Eric, Denis and Anatoly all
> > qualifying) to sponsor your request.  Obviously that mostly makes
> > sense if you expect to contribute more than a handfull of patches
> > over the course of the next year, which we do hope will be the
> > case. :-)

> Thanks for that hint. Is that the "Write after Approval" section in
> MAINTAINERS?

Yes.

> However, I have bunch of questions for that I don't find answers in
> the wiki. As it is very easy *not* to find something in the gcc wiki,
> I probably just missed it...
> 
> 1) What is the exact procedure for this? Will it be like fsf copyright
>    assignment and take more than a year (at least in my case) to pass?

Somebody says "you can mention me as sponsor", you put him or her in the
approval in the form you fill out after reading
http://gcc.gnu.org/svnwrite.html and wait for the login to be approved.
In my case, it took 3 hours, but I wouldn't worry if it took a weekend
plus a couple of workdays until one of the sourceware people has time.

> 2) Changelogs and svn logs are always in sync. Is there some setup
>    in the svn server to do this magic? Are there custom scripts for
>    this or is it all hand-made?

FWIW, some people use a script named mklog[1], a while ago I wrote
vc-chlog[2] for generating stub ChangeLog entries.  I generate the svn
log entries from the ChangeLog entries with a couple of editor macros,
dunno if there's public scripting for that.

> 3) Ditto for PRs that get a notification as soon as a patch goes
>    upstream.

The mechanism is triggered by the
        PR category/12345

entries in the log.  The category is the 'Component' field in bugzilla.

> 4) Will there be someone like a mentor who I could ask such
>    questions or get useful hints?

I'm not aware of a special mentor program for new contributors, but
people here assume that beginners make beginner errors, read and search
mailing lists and/or the wiki and web pages, and learn.  I wouldn't
worry too much, you'll be corrected.  ;-)

Cheers,
Ralf

[1] http://sourceware.org/gdb/wiki/DeveloperTips
[2] http://www.gnu.org/software/vc-dwim/

Re: [Ping #2][Patch, testsuite]: Don't xfail sibcalls on AVR

[Gerald Pfeifer]

On Sat, 9 Apr 2011, Ralf Wildenhues wrote:
>> 4) Will there be someone like a mentor who I could ask such
>>    questions or get useful hints?
> I'm not aware of a special mentor program for new contributors

I would say, however, that the one approving the request for a
gcc.gnu.org account should be ready (and offering) to help.

Gerald

RE: [Ping][Patch, testsuite]: Don't xfail sibcalls on AVR

[Weddington, Eric]

> -----Original Message-----
> From: Georg-Johann Lay [mailto:avr@gjlay.de]
> Sent: Tuesday, March 29, 2011 3:00 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Anatoly Sokolov; Denis Chertykov; Weddington, Eric
> Subject: [Ping][Patch, testsuite]: Don't xfail sibcalls on AVR
> 
> Target avr now supports tail calls, so don't xfail on that.
> 
> testsuite/
> 
> 2011-03-29  Georg-Johann Lay  <avr@gjlay.de>
> 
> 	* gcc.dg/sibcall-3.c: Don't xfail on AVR.
> 	* gcc.dg/sibcall-4.c: Don't xfail on AVR.

Committed. Thanks for the patch, Johann.

Eric