public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Guenther <rguenther@suse.de>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org, mjambor@suse.cz
Subject: Re: Remove vtable_method field in cgraph_node
Date: Mon, 18 Apr 2011 09:27:00 -0000	[thread overview]
Message-ID: <alpine.LNX.2.00.1104181054500.810@zhemvz.fhfr.qr> (raw)
In-Reply-To: <20110417230342.GB23956@kam.mff.cuni.cz>

On Mon, 18 Apr 2011, Jan Hubicka wrote:

> > > notice that OBJ_TYPE_REF is useless since foo got devitualized and it holds alive
> > > the useless s._vptr.S = &_ZTV1S[2].  We want to drop OBJ_TYPE_REF at time we fold
> > > first argument to constant.
> > 
> > At some point we dropped all OBJ_TYPE_REF with direct fn but that lead to
> > issues.  I'll try to dig up what that was.
> 
> Hah, that sounds really scary, given that OBJ_TYPE_REF should be semantically no-op.
> We definitely drop them in tree-ssa-ccp, so if we need to preserve them somehow, that is
> probably case where we should.

Ah, no.  We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF
expr in CCP and defer to fold_stmt to eventually "devirtualize" it.
See PR45878.  Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF
for the non-devirtualized call as well.  As both cases were because
of type conversion issues this should be fixed with separating the
call function type as we do now.

I'll look into handling copyprop and FRE similarly.

Richard.

  reply	other threads:[~2011-04-18  8:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17 17:26 Jan Hubicka
2011-04-17 21:27 ` Richard Guenther
2011-04-18  0:51   ` Jan Hubicka
2011-04-18  9:27     ` Richard Guenther [this message]
2011-04-18 15:40       ` Jan Hubicka
2011-04-18 15:41         ` Richard Guenther
2011-04-18 16:27           ` Jan Hubicka
2011-04-20 13:43 ` Martin Jambor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1104181054500.810@zhemvz.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).