From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4036 invoked by alias); 22 May 2011 21:29:22 -0000 Received: (qmail 4027 invoked by uid 22791); 22 May 2011 21:29:21 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from relay02.pair.com (HELO relay02.pair.com) (209.68.5.16) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 22 May 2011 21:29:07 +0000 Received: (qmail 30840 invoked from network); 22 May 2011 21:29:06 -0000 Received: from 91.186.144.116 (HELO ?192.168.0.130?) (91.186.144.116) by relay02.pair.com with SMTP; 22 May 2011 21:29:06 -0000 X-pair-Authenticated: 91.186.144.116 Date: Mon, 23 May 2011 07:13:00 -0000 From: Gerald Pfeifer To: Jack Howarth , Janis Johnson cc: gcc-patches@gcc.gnu.org, Richard Guenther Subject: Re: [PATCH][4.6] detect C++ errors to fix 2288 and 18770 In-Reply-To: <20110522193335.GA9729@bromo.med.uc.edu> Message-ID: References: <1268945454.2219.13.camel@janis-laptop> <20110522193335.GA9729@bromo.med.uc.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01583.txt.bz2 On Sun, 22 May 2011, Jack Howarth wrote: >> 2010-03-18 Janis Johnson >> >> gcc/cp >> PR c++/2288 >> PR c++/18770 >> * name-lookup.h (enum scope_kind): Add sk_cond. >> * name-lookup.c (pushdecl_maybe_friend): Get scope of shadowed local. >> Detect and report error for redeclaration from for-init or if >> or switch condition. >> (begin_scope): Handle sk_cond. >> * semantics.c (begin_if_stmt): Use sk_cond. >> (begin switch_stmt): Ditto. >> >> gcc/testsuite/ >> PR c++/2288 >> PR c++/18770 >> * g++.old-deja/g++.jason/cond.C: Remove xfails. >> * g++.dg/parse/pr18770.C: New test. > Any chance we can get this committed to gcc trunk while in 4.7 stage 1 > (since it was already approved for 4.6 stage 1 and never applied... > http://gcc.gnu.org/ml/gcc-patches/2010-05/msg00264.html). It would be > nice to have in gcc 4.7 so that other open source projects that only > build against g++ would be alerted to fix their sources. It's my understanding that an approved patch can be committed by anyone with write access unless it is retracted or there is some other reason not to. Customary that is left to the submitter if she has write access, of course. In the concrete case, Janis is now reachable at janisjo@codesourcery.com according to the gcc/MAINTAINERS file, by the way. Including her... Gerald