public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Fix PR49893
@ 2011-07-29  9:37 Richard Guenther
  0 siblings, 0 replies; only message in thread
From: Richard Guenther @ 2011-07-29  9:37 UTC (permalink / raw)
  To: gcc-patches


This fixes a latent issue in predictive commoning - we shouldn't try
to optimize invariant volatile references.  The following patch simply
disables handling of all volatile references similar to possibly
throwing ones.

Bootstrap and regtest in progress on x86_64-unknown-linux-gnu.

Richard.

2011-07-29  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/49893
	* tree-predcom.c (suitable_reference_p): Volatile references
	are not suitable.

Index: gcc/tree-predcom.c
===================================================================
*** gcc/tree-predcom.c	(revision 176869)
--- gcc/tree-predcom.c	(working copy)
*************** suitable_reference_p (struct data_refere
*** 598,603 ****
--- 598,604 ----
    tree ref = DR_REF (a), step = DR_STEP (a);
  
    if (!step
+       || TREE_THIS_VOLATILE (ref)
        || !is_gimple_reg_type (TREE_TYPE (ref))
        || tree_could_throw_p (ref))
      return false;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-29  8:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-29  9:37 [PATCH] Fix PR49893 Richard Guenther

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).