public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org, Denis Chertykov <chertykov@gmail.com>,
	    Eric Weddington <eric.weddington@atmel.com>
Subject: Re: [Patch,wwwdocs,AVR]: AVR release notes
Date: Sun, 12 Feb 2012 22:23:00 -0000	[thread overview]
Message-ID: <alpine.LNX.2.00.1202122310180.5509@gerinyyl.fvgr> (raw)
In-Reply-To: <4F26A14D.4050207@gjlay.de>

On Mon, 30 Jan 2012, Georg-Johann Lay wrote:
>> "Support for...has been added" (also typo: beed -> been)

Hmm, this still seems to be in the latest version?

> Is "C code" better? Or C-code? Without the extension, inline assembler 
> must be used to get correct code, using C like a = b or 
> pstruct->component will yield wrong code without the extensions if b
> or *pstruct is located in flash.

Thanks for the background.  I really like how you have changed this
in the new version of the patch!

>> +    <li>Support for AVR-specific built-in functions has beed added.</li>
>> Which ones?
> Must they all be named explicitly? Or is it ok to link to onlinedocs? 
> I'd prefer a link to the explanation in onlinedocs but I am unsure how 
> stable the links are as docs evolve over time/versions.

If you think it's not beneficial, we don't have to do anything.  The
links should be rather stable in general (and I am running link checks
somewhat regularly).

+    <li>Support has beed added for the built-in, 24-bit, signed and unsigned
+      integer types <code>__int24</code> and <code>__uint24</code>.</li>

I believe that should be "signed and unsigned 24-bit integer types"
(omitting "built-in" should be fine, but in any case without commas).

> What does "need no &nbsp;" mean? Nothing at ",etc." all or blank ", etc."?

I'd just use a regular space instead of &nbsp; in that case.

>> What is ".progmen"?  Perhaps paraphrase this briefly?
> Not easy without getting into too much technical details...

Okay.

> Attached an updated patch as there were many changes and so that Eric 
> and Denis can easier catch up.

Looks good!  Please fix the one typo, and consider the other comments
as well, and go ahead and commit this I'd say.  We can always make
further changes later.

This looks like an impressive release for AVR!

Gerald

  parent reply	other threads:[~2012-02-12 22:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 18:30 Georg-Johann Lay
2012-01-25 15:57 ` Ping #1: " Georg-Johann Lay
2012-01-29 23:27 ` Gerald Pfeifer
2012-01-30 13:55   ` Georg-Johann Lay
2012-01-30 18:59     ` Weddington, Eric
2012-01-30 23:07       ` Georg-Johann Lay
2012-02-12 22:23     ` Gerald Pfeifer [this message]
2012-02-13 14:28       ` Weddington, Eric
2012-02-15 17:04       ` Georg-Johann Lay
2012-02-15 17:17         ` Georg-Johann Lay
2015-04-11  0:02           ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1202122310180.5509@gerinyyl.fvgr \
    --to=gerald@pfeifer.com \
    --cc=avr@gjlay.de \
    --cc=chertykov@gmail.com \
    --cc=eric.weddington@atmel.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).