From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-331260-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 19635 invoked by alias); 6 Nov 2012 22:15:02 -0000
Received: (qmail 19593 invoked by uid 22791); 6 Nov 2012 22:15:00 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from ainaz.pair.com (HELO ainaz.pair.com) (209.68.2.66)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 22:14:57 +0000
Received: from [149.44.171.145] (nat.nue.novell.com [195.135.221.2])	by ainaz.pair.com (Postfix) with ESMTPSA id 6374B3F412;	Tue,  6 Nov 2012 17:14:55 -0500 (EST)
Date: Tue, 06 Nov 2012 22:15:00 -0000
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Sriraman Tallam <tmsriram@google.com>
cc: Jason Merrill <jason@redhat.com>, David Li <davidxl@google.com>,     "H.J. Lu" <hjl.tools@gmail.com>,     gcc-patches List <gcc-patches@gcc.gnu.org>, Jan Hubicka <jh@suse.cz>,     Diego Novillo <dnovillo@google.com>
Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064)
In-Reply-To: <CAAs8Hmz7aDcN+2YGfH8ixrgUt+A=PuTt8ZzPhUVeQTgSWGP-Ww@mail.gmail.com>
Message-ID: <alpine.LNX.2.00.1211061911490.3550@tuna.site>
References: <CAAs8HmxHF38ktt6syjWp-MpjiX+6NcXh7_8Xn6iKnAiF2vRymQ@mail.gmail.com> <5008708E.1030109@redhat.com> <CAAs8Hmy7h5SGkJ+D5v_DnXs-h4B2d_YWEcstufb5=SowbVBp0Q@mail.gmail.com> <CAAs8HmyKPG_LxxxP2ngkGTFAKUPXQDJsbbsrOB_oAP0ViyER3g@mail.gmail.com> <506F27AF.3070805@redhat.com> <CAAs8HmxEod=EJNyUjrD0-WaP0-cB5o_AN9oc2O2ryu--MRQf4w@mail.gmail.com> <CAAs8Hmyy9S+Ucg6rTDU3xGMg8JEaa0r3rNjbxhbjuk9H8Sb6wg@mail.gmail.com> <50816D63.3020908@google.com> <CAAs8HmzZUnGq9G3KQ-wesKOHVWJBHn1n0zyFhEOPxo+i0PBrww@mail.gmail.com> <CAAs8HmxXfBdsLOrhEnd=syUXfbo5gKa-QkdWQG=4bUeWOPrSfQ@mail.gmail.com> <20121026155447.GA4348@atrey.karlin.mff.cuni.cz> <CAAs8Hmw0KBhKp_3qe0gzVi1jw=LVg6GD1cv-++=Kh3OjThwB+A@mail.gmail.com> <50902624.3020705@redhat.com> <CAAs8Hmw09giv-5_v0irhByTjTJV=kD58rCAD2SAz7M8zrwjBOA@mail.gmail.com> <50912F66.3030707@redhat.com> <CAAs8Hmz4CNzyJHAPoRkEe5gtL3YXSqoNHGMeZdm0uJujFHkMhQ@mail.gmail.com> <CAAs8Hmz7aDcN+2YGfH8ixrgUt+A=PuTt8ZzPhUVeQTgSWGP-Ww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-11/txt/msg00582.txt.bz2

On Mon, 5 Nov 2012, Sriraman Tallam wrote:
>    I have now committed the attached patch.

...and broke bootstrap on *-unknown-freebsd* and other targets
that way:

   /scratch2/tmp/gerald/gcc-HEAD/gcc/config/i386/i386.c:28820:1: error: 
   'tree_node* make_dispatcher_decl(tree)' defined but not used 
   [-Werror=unused-function]
    make_dispatcher_decl (const tree decl)
    ^
   cc1plus: all warnings being treated as errors

To restore bootstrap, I applied the patch below after testing on
i386-unknown-freebsd10.0.

Gerald


2012-11-06  Gerald Pfeifer  <gerald@pfeifer.com>

	* config/i386/i386.c (make_dispatcher_decl): Guard with
	ASM_OUTPUT_TYPE_DIRECTIVE and HAVE_GNU_INDIRECT_FUNCTION.

Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c	(revision 193259)
+++ config/i386/i386.c	(working copy)
@@ -28813,6 +28813,8 @@
   return global_var_name;
 }
 
+#if defined (ASM_OUTPUT_TYPE_DIRECTIVE) && HAVE_GNU_INDIRECT_FUNCTION
+
 /* Make a dispatcher declaration for the multi-versioned function DECL.
    Calls to DECL function will be replaced with calls to the dispatcher
    by the front-end.  Return the decl created.  */
@@ -28850,6 +28852,8 @@
   return func_decl;  
 }
 
+#endif
+
 /* Returns true if decl is multi-versioned and DECL is the default function,
    that is it is not tagged with target specific optimization.  */