Re: [PATCH, PR 55078] Let indirect inlining look at ipa-cp lattices

[Richard Biener <rguenther@suse.de>]

On Thu, 6 Dec 2012, Jan Hubicka wrote:

> > Hi,
> > 
> > the patch below re-stores a check in the inlining machinery that makes
> > sure growth estimates match the reality after inlining.  However, in
> > order to do that, I had to teach indirect inlining to look at IPA-CP
> > data because that's what the inlining estimates do.  Even though this
> > makes indirect inlining slightly more powerful, the change is not big
> > and so I hope it qualifies even though we are in stage 3 now.
> > 
> > The patch has passed bootstrap and testing on x86_64-linux.  OK for
> > trunk?
> > 
> > Thanks,
> > 
> > Martin
> > 
> > 
> > 2012-12-05  Martin Jambor  <mjambor@suse.cz>
> > 
> > 	PR middle-end/55078
> > 	* ipa-inline-transform.c (inline_call): Turn #if 0 to #ifdef
> > 	ENABLE_CHECKING.
> > 	* ipa-prop.c (try_make_edge_direct_simple_call): Use
> > 	ipa_value_from_jfunc.
> > 	(try_make_edge_direct_virtual_call): Likewise.
> > 	(update_indirect_edges_after_inlining): Lookup new_root_info and pass
> > 	it to the functions above.
> 
> The patch is OK.
> I think it would make sense to have it in stage3, Richi/Jakub can you comment
> from RM perspective?

It fixes a bug and thus is appropriate for stage3 by the rulebook.

Thanks,
Richard.