From: Richard Biener <rguenther@suse.de>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org, laurent@guerby.net
Subject: Re: [PATCH] Include gmp.h from system.h to fix PR54659
Date: Fri, 21 Dec 2012 12:23:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.00.1212211320300.6889@zhemvz.fhfr.qr> (raw)
In-Reply-To: <1566647.uGP6oVgNTF@polaris>
On Fri, 21 Dec 2012, Eric Botcazou wrote:
> > This runs into issues with Ada which basically does (ugh)
> >
> > #ifdef __cplusplus
> > extern "C" {
> > #endif
> >
> > #include "system.h"
> >
> > #endif __cplusplus
> > }
> > #endif
> >
> > which of course wrecks any system header doing __cplusplus
> > conditional stuff (such as gmp.h including iosfwd). The patch
> > un-kludges this by wrapping system.h inside extern "C++" when
> > compiling with the C++ frontend.
> >
> > But - really - Ada people - can you fix that on your side please?
> > (CCed people doing r176210)
>
> Like so? I cannot believe that all this fuss was about moving 3 lines within
> less than a dozen of files...
The patch looks fine to me (though it's not 100% obvious to me as not only
system headers are now no longer in extern "C" - which is why I simply
tried the un-wrapping). So, if you think that's ok please commit it.
It certainly helps not to rely on compilers handling nested extern "foo"
correctly ...
Thanks,
Richard.
next prev parent reply other threads:[~2012-12-21 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 11:50 Richard Biener
2012-12-21 12:18 ` Eric Botcazou
2012-12-21 12:23 ` Richard Biener [this message]
2012-12-21 12:33 ` Eric Botcazou
2012-12-21 13:03 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1212211320300.6889@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=laurent@guerby.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).