public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [wwwdocs] mention caret diagnostics and Wpedantic
Date: Fri, 11 Jan 2013 11:14:00 -0000	[thread overview]
Message-ID: <alpine.LNX.2.00.1301111210440.2028@tuna.site> (raw)
In-Reply-To: <CAESRpQAHnN8zrrussfdo2JAjkpFUxe=9yZ=ujg2uh8NxDDpFFw@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 788 bytes --]

On Thu, 10 Jan 2013, Manuel López-Ibáñez wrote:
> I haven't heard any complaints about the caret diagnostics being
> enabled by default, so I am tempted to think it will stay like it is
> for GCC 4.8. This patch documents that and also the new -Wpedantic.
> OK?

Nice!

+    <li>By default, each diagnostic emitted includes the original

How about adding "now includes" to emphasize this is new behavior,
as opposed to a summary/introduction ahead of the next item?

+  <code>-Werror=pedantic</code> is <b>not</b> equivalent to

Can you make this <strong>not</strong> (or just <em>not</em>)?

+  <code>-Wno-pedantic</code>.

I believe you'll want to close this with </li> at the end.

Looks good to me.

Gerald

PS: Your mailer attached the patch as Application/OCTET-STREAM, not
text.

      reply	other threads:[~2013-01-11 11:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 10:00 Manuel López-Ibáñez
2013-01-11 11:14 ` Gerald Pfeifer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1301111210440.2028@tuna.site \
    --to=gerald@pfeifer.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=lopezibanez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).