From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6604 invoked by alias); 15 Jan 2013 09:25:46 -0000 Received: (qmail 6578 invoked by uid 22791); 15 Jan 2013 09:25:45 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 09:25:35 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 5A8A2A51F6; Tue, 15 Jan 2013 10:25:34 +0100 (CET) Date: Tue, 15 Jan 2013 09:25:00 -0000 From: Richard Biener To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix up ICE with reduction % (PR tree-optimization/55955) In-Reply-To: <20130114204932.GR7269@tucnak.redhat.com> Message-ID: References: <20130114204932.GR7269@tucnak.redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00767.txt.bz2 On Mon, 14 Jan 2013, Jakub Jelinek wrote: > Hi! > > For *SHIFT_EXPR/*ROTATE_EXPR with VECTOR_TYPE types, optab_for_tree_code > requires us to decide if we want optab_vector or optab_scalar. It is likely > not worth it to handle these four, they would fail soon anyway. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok. Thanks, Richard. > 2013-01-14 Jakub Jelinek > > PR tree-optimization/55955 > * tree-vect-loop.c (vectorizable_reduction): Give up early on > *SHIFT_EXPR and *ROTATE_EXPR codes. > > * gcc.c-torture/compile/pr55955.c: New test. > > --- gcc/tree-vect-loop.c.jj 2013-01-11 09:02:55.000000000 +0100 > +++ gcc/tree-vect-loop.c 2013-01-14 12:21:29.359018748 +0100 > @@ -4776,6 +4776,17 @@ vectorizable_reduction (gimple stmt, gim > { > /* 4. Supportable by target? */ > > + if (code == LSHIFT_EXPR || code == RSHIFT_EXPR > + || code == LROTATE_EXPR || code == RROTATE_EXPR) > + { > + /* Shifts and rotates are only supported by vectorizable_shifts, > + not vectorizable_reduction. */ > + if (dump_enabled_p ()) > + dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, > + "unsupported shift or rotation."); > + return false; > + } > + > /* 4.1. check support for the operation in the loop */ > optab = optab_for_tree_code (code, vectype_in, optab_default); > if (!optab) > --- gcc/testsuite/gcc.c-torture/compile/pr55955.c.jj 2013-01-14 12:23:28.273324350 +0100 > +++ gcc/testsuite/gcc.c-torture/compile/pr55955.c 2013-01-14 12:23:14.000000000 +0100 > @@ -0,0 +1,12 @@ > +/* PR tree-optimization/55955 */ > + > +int b; > + > +void > +foo (int x) > +{ > + int a; > + for (a = x; a < 2; a++) > + for (b = 0; b < 2; b++) > + *(unsigned short *) 0x100000UL %= 46; > +} > > Jakub > > -- Richard Biener SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend