From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27179 invoked by alias); 5 Mar 2013 09:06:26 -0000 Received: (qmail 27166 invoked by uid 22791); 5 Mar 2013 09:06:25 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,TW_TM X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 09:06:20 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 21BC5A51F4; Tue, 5 Mar 2013 10:06:19 +0100 (CET) Date: Tue, 05 Mar 2013 09:06:00 -0000 From: Richard Biener To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix vect_create_epilog_for_reduction memory leaks (PR middle-end/56461) In-Reply-To: <20130304210333.GS12913@tucnak.redhat.com> Message-ID: References: <20130304210333.GS12913@tucnak.redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00154.txt.bz2 On Mon, 4 Mar 2013, Jakub Jelinek wrote: > Hi! > > vect_create_epilog_for_reduction leaks memory both from the inner_phis > vector not being released for double_reduc, and also for stmt_vec_info > it creates (because those are added for stmts added into exit_bb, i.e. > after loop, which destroy_loop_vec_info doesn't free). Fixed thusly, > bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok. Thanks, Richard. > 2013-03-04 Jakub Jelinek > > PR middle-end/56461 > * tree-vect-stmts.c (free_stmt_vec_info_vec): Call > free_stmt_vec_info on any left-over stmt_vec_info in the vector. > * tree-vect-loop.c (vect_create_epilog_for_reduction): Release > inner_phis vector. > > --- gcc/tree-vect-stmts.c.jj 2013-03-04 11:07:33.000000000 +0100 > +++ gcc/tree-vect-stmts.c 2013-03-04 12:14:16.111393716 +0100 > @@ -5969,6 +5969,11 @@ init_stmt_vec_info_vec (void) > void > free_stmt_vec_info_vec (void) > { > + unsigned int i; > + vec_void_p info; > + FOR_EACH_VEC_ELT (stmt_vec_info_vec, i, info) > + if (info != NULL) > + free_stmt_vec_info (STMT_VINFO_STMT ((stmt_vec_info) info)); > gcc_assert (stmt_vec_info_vec.exists ()); > stmt_vec_info_vec.release (); > } > --- gcc/tree-vect-loop.c.jj 2013-03-04 11:01:48.000000000 +0100 > +++ gcc/tree-vect-loop.c 2013-03-04 12:17:09.934351015 +0100 > @@ -4487,8 +4487,9 @@ vect_finalize_reduction: > } > > scalar_results.release (); > + inner_phis.release (); > new_phis.release (); > -} > +} > > > /* Function vectorizable_reduction. > > Jakub > > -- Richard Biener SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend