From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22680 invoked by alias); 8 Jul 2011 03:33:25 -0000 Received: (qmail 22671 invoked by uid 22791); 8 Jul 2011 03:33:24 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mailout-de.gmx.net) (213.165.64.23) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 08 Jul 2011 03:33:09 +0000 Received: (qmail invoked by alias); 08 Jul 2011 03:33:07 -0000 Received: from mon.egee-see.org (EHLO [139.91.70.93]) [139.91.70.93] by mail.gmx.net (mp011) with SMTP; 08 Jul 2011 05:33:07 +0200 Date: Fri, 08 Jul 2011 03:52:00 -0000 From: Dimitrios Apostolou To: gcc-patches@gcc.gnu.org cc: Paolo Bonzini , Steven Bosscher Subject: Re: [df-scan.c] Optimise DF_REFs ordering in collection_rec, use HARD_REG_SETs instead of bitmaps In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00581.txt.bz2 To document the gains from the bitmaps, here is (part of) the annotated source from callgrind profiler, showing instruction count. Before: 1,154,400 if (bitmap_bit_p(regs_invalidated_by_call_regset, i) 8,080,800 => bitmap.c:bitmap_bit_p (192400x) 1,021,200 && !bitmap_bit_p (&defs_generated, i) 5,106,000 => bitmap.c:bitmap_bit_p (170200x) 340,400 && (!is_sibling_call . || !bitmap_bit_p (df->exit_block_uses, i) . || refers_to_regno_p (i, i+1, . crtl->return_rtx, NULL))) 2,053,500 df_ref_record (DF_REF_BASE, collection_rec, regno_reg_rtx[i 35,279,934 => df-scan.c:df_ref_record (170200x) . NULL, bb, insn_info, DF_REF_REG_DEF, . DF_REF_MAY_CLOBBER | flags); . } After: 1,346,800 if (TEST_HARD_REG_BIT(regs_invalidated_by_call, i) 510,600 && !TEST_HARD_REG_BIT (defs_generated, i) 340,400 && (!is_sibling_call . || !bitmap_bit_p (df->exit_block_uses, i) . || refers_to_regno_p (i, i+1, . crtl->return_rtx, NULL))) 2,057,200 df_ref_record (DF_REF_BASE, collection_rec, regno_reg_rtx[i 35,279,934 => df-scan.c:df_ref_record (170200x) . NULL, bb, insn_info, DF_REF_REG_DEF, . DF_REF_MAY_CLOBBER | flags); . } Dimitris