From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17333 invoked by alias); 8 Jul 2011 03:52:10 -0000 Received: (qmail 17324 invoked by uid 22791); 8 Jul 2011 03:52:09 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mailout-de.gmx.net) (213.165.64.22) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 08 Jul 2011 03:51:55 +0000 Received: (qmail invoked by alias); 08 Jul 2011 03:51:53 -0000 Received: from mon.egee-see.org (EHLO [139.91.70.93]) [139.91.70.93] by mail.gmx.net (mp064) with SMTP; 08 Jul 2011 05:51:53 +0200 Date: Fri, 08 Jul 2011 06:36:00 -0000 From: Dimitrios Apostolou To: gcc-patches@gcc.gnu.org cc: Paolo Bonzini , Steven Bosscher Subject: Re: [df-scan.c] Optimise DF_REFs ordering in collection_rec, use HARD_REG_SETs instead of bitmaps In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-982218406-1310097114=:1237" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00582.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-982218406-1310097114=:1237 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Content-length: 441 And here is the patch that breaks things. By moving df_defs_record() *after* df_get_call_refs() most times collection_rec remains sorted, and about 50M instructions are avoided in qsort() calls of df_canonize_collection_rec(). Unfortunately this does not work. Sometimes cc1 crashes, for example because regstack is empty in subst_stack_regs_in_debug_insn(). Any ideas for ensuring proper ordering of collection_rec? Thanks, Dimitris --8323328-982218406-1310097114=:1237 Content-Type: TEXT/plain; name=df1b-broken.diff Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=df1b-broken.diff Content-length: 3506 PT09IG1vZGlmaWVkIGZpbGUgJ2djYy9kZi1zY2FuLmMnDQotLS0gZ2NjL2Rm LXNjYW4uYwkyMDExLTA3LTA4IDAxOjI4OjU1ICswMDAwDQorKysgZ2NjL2Rm LXNjYW4uYwkyMDExLTA3LTA4IDAzOjM4OjM4ICswMDAwDQpAQCAtMzQxMiw4 ICszNDEyLDkgQEANCiAgIFZFQ190cnVuY2F0ZSAoZGZfcmVmLCBjb2xsZWN0 aW9uX3JlYy0+ZXFfdXNlX3ZlYywgMCk7DQogICBWRUNfdHJ1bmNhdGUgKGRm X213X2hhcmRyZWdfcHRyLCBjb2xsZWN0aW9uX3JlYy0+bXdfdmVjLCAwKTsN CiANCi0gIC8qIFJlY29yZCByZWdpc3RlciBkZWZzLiAgKi8NCi0gIGRmX2Rl ZnNfcmVjb3JkIChjb2xsZWN0aW9uX3JlYywgUEFUVEVSTiAoaW5zbl9pbmZv LT5pbnNuKSwgYmIsIGluc25faW5mbywgMCk7DQorICBpZiAoQ0FMTF9QIChp bnNuX2luZm8tPmluc24pKQ0KKyAgICBkZl9nZXRfY2FsbF9yZWZzIChjb2xs ZWN0aW9uX3JlYywgYmIsIGluc25faW5mbywNCisJCSAgICAgIChpc19jb25k X2V4ZWMpID8gREZfUkVGX0NPTkRJVElPTkFMIDogMCk7DQogDQogICAvKiBQ cm9jZXNzIFJFR19FUVVJVi9SRUdfRVFVQUwgbm90ZXMuICAqLw0KICAgZm9y IChub3RlID0gUkVHX05PVEVTIChpbnNuX2luZm8tPmluc24pOyBub3RlOw0K QEAgLTM0MjEsMzMgKzM0MjIsMzMgQEANCiAgICAgew0KICAgICAgIHN3aXRj aCAoUkVHX05PVEVfS0lORCAobm90ZSkpDQogICAgICAgICB7DQorCSAgLyog Zmlyc3Qgd3JpdGUgREZfUkVGX0JBU0UgKi8NCisgICAgICAgIGNhc2UgUkVH X05PTl9MT0NBTF9HT1RPOg0KKyAgICAgICAgICAvKiBUaGUgZnJhbWUgcHRy IGlzIHVzZWQgYnkgYSBub24tbG9jYWwgZ290by4gICovDQorICAgICAgICAg IGRmX3JlZl9yZWNvcmQgKERGX1JFRl9CQVNFLCBjb2xsZWN0aW9uX3JlYywN CisgICAgICAgICAgICAgICAgICAgICAgICAgcmVnbm9fcmVnX3J0eFtGUkFN RV9QT0lOVEVSX1JFR05VTV0sDQorICAgICAgICAgICAgICAgICAgICAgICAg IE5VTEwsIGJiLCBpbnNuX2luZm8sDQorICAgICAgICAgICAgICAgICAgICAg ICAgIERGX1JFRl9SRUdfVVNFLCAwKTsNCisjaWYgIUhBUkRfRlJBTUVfUE9J TlRFUl9JU19GUkFNRV9QT0lOVEVSDQorICAgICAgICAgIGRmX3JlZl9yZWNv cmQgKERGX1JFRl9CQVNFLCBjb2xsZWN0aW9uX3JlYywNCisgICAgICAgICAg ICAgICAgICAgICAgICAgcmVnbm9fcmVnX3J0eFtIQVJEX0ZSQU1FX1BPSU5U RVJfUkVHTlVNXSwNCisgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwg YmIsIGluc25faW5mbywNCisgICAgICAgICAgICAgICAgICAgICAgICAgREZf UkVGX1JFR19VU0UsIDApOw0KKyNlbmRpZg0KKyAgICAgICAgICBicmVhazsN CiAgICAgICAgIGNhc2UgUkVHX0VRVUlWOg0KICAgICAgICAgY2FzZSBSRUdf RVFVQUw6DQogICAgICAgICAgIGRmX3VzZXNfcmVjb3JkIChjb2xsZWN0aW9u X3JlYywNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICZYRVhQIChub3Rl LCAwKSwgREZfUkVGX1JFR19VU0UsDQogICAgICAgICAgICAgICAgICAgICAg ICAgICBiYiwgaW5zbl9pbmZvLCBERl9SRUZfSU5fTk9URSk7DQogICAgICAg ICAgIGJyZWFrOw0KLSAgICAgICAgY2FzZSBSRUdfTk9OX0xPQ0FMX0dPVE86 DQotICAgICAgICAgIC8qIFRoZSBmcmFtZSBwdHIgaXMgdXNlZCBieSBhIG5v bi1sb2NhbCBnb3RvLiAgKi8NCi0gICAgICAgICAgZGZfcmVmX3JlY29yZCAo REZfUkVGX0JBU0UsIGNvbGxlY3Rpb25fcmVjLA0KLSAgICAgICAgICAgICAg ICAgICAgICAgICByZWdub19yZWdfcnR4W0ZSQU1FX1BPSU5URVJfUkVHTlVN XSwNCi0gICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgYmIsIGluc25f aW5mbywNCi0gICAgICAgICAgICAgICAgICAgICAgICAgREZfUkVGX1JFR19V U0UsIDApOw0KLSNpZiAhSEFSRF9GUkFNRV9QT0lOVEVSX0lTX0ZSQU1FX1BP SU5URVINCi0gICAgICAgICAgZGZfcmVmX3JlY29yZCAoREZfUkVGX0JBU0Us IGNvbGxlY3Rpb25fcmVjLA0KLSAgICAgICAgICAgICAgICAgICAgICAgICBy ZWdub19yZWdfcnR4W0hBUkRfRlJBTUVfUE9JTlRFUl9SRUdOVU1dLA0KLSAg ICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBiYiwgaW5zbl9pbmZvLA0K LSAgICAgICAgICAgICAgICAgICAgICAgICBERl9SRUZfUkVHX1VTRSwgMCk7 DQotI2VuZGlmDQotICAgICAgICAgIGJyZWFrOw0KICAgICAgICAgZGVmYXVs dDoNCiAgICAgICAgICAgYnJlYWs7DQogICAgICAgICB9DQogICAgIH0NCiAN Ci0gIGlmIChDQUxMX1AgKGluc25faW5mby0+aW5zbikpDQotICAgIGRmX2dl dF9jYWxsX3JlZnMgKGNvbGxlY3Rpb25fcmVjLCBiYiwgaW5zbl9pbmZvLA0K LQkJICAgICAgKGlzX2NvbmRfZXhlYykgPyBERl9SRUZfQ09ORElUSU9OQUwg OiAwKTsNCisgIC8qIFJlY29yZCByZWdpc3RlciBkZWZzLiAgKi8NCisgIGRm X2RlZnNfcmVjb3JkIChjb2xsZWN0aW9uX3JlYywgUEFUVEVSTiAoaW5zbl9p bmZvLT5pbnNuKSwgYmIsIGluc25faW5mbywgMCk7DQogDQogICAvKiBSZWNv cmQgdGhlIHJlZ2lzdGVyIHVzZXMuICAqLw0KICAgZGZfdXNlc19yZWNvcmQg KGNvbGxlY3Rpb25fcmVjLA0KDQo= --8323328-982218406-1310097114=:1237--