From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82696 invoked by alias); 31 Jan 2018 12:16:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 82634 invoked by uid 89); 31 Jan 2018 12:16:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.ispras.ru Received: from bran.ispras.ru (HELO smtp.ispras.ru) (83.149.199.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Jan 2018 12:16:38 +0000 Received: from monopod.intra.ispras.ru (monopod.intra.ispras.ru [10.10.3.121]) by smtp.ispras.ru (Postfix) with ESMTP id 83CF6203C6; Wed, 31 Jan 2018 15:16:35 +0300 (MSK) Date: Wed, 31 Jan 2018 13:33:00 -0000 From: Alexander Monakov To: Wilco Dijkstra cc: GCC Patches , nd Subject: Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20.13 (LNX 116 2015-12-14) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2018-01/txt/msg02441.txt.bz2 On Wed, 31 Jan 2018, Wilco Dijkstra wrote: > The comparison order for SCHED_PRESSURE_MODEL is incorrect. If either > instruction is not in target_bb, the ordering is not well defined. To fix > this, give all instructions in target_bb the highest priority and sort all > other instructions behind it. This way instructions in target_bb will be > sorted using the pressure model, and instructions outside it will use > RFS_DEP_COUNT and/or RFS_TIE for their order. This appears to be the same issue as PR 83459; please add rtl-optimization/83459 to ChangeLog if approved. > PR rlt-optimization/84068 > * haifa-sched.c (rank_for_schedule): Fix SCHED_PRESSURE_MODEL sorting. > > PR rlt-optimization/84068 Note typos in category name (s/rlt/rtl). Alexander