From: Alexander Monakov <amonakov@ispras.ru>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] gcc_qsort: source code changes
Date: Fri, 11 May 2018 13:12:00 -0000 [thread overview]
Message-ID: <alpine.LNX.2.20.13.1805111548070.1437@monopod.intra.ispras.ru> (raw)
In-Reply-To: <CAFiYyc3d=K48jEBdG3wZ9pZAUWRGt9usMM8ZbcPhAvS1h5je=A@mail.gmail.com>
On Fri, 11 May 2018, Richard Biener wrote:
> Looks good to me. As additional enhancement we might want to provide
> (even unconditionally?)
> the glibc qsort_r() interface. I remember adding various globals to
> pass down state to the comparator...
Thanks. I have no plans w.r.t qsort_r, but OTOH a stable sort interface
can be added with tiny size/speed cost, and the sole in-tree use can be
converted :)
> I agree self-tests might be good to have. Also it looks like the
> qsort-checking may now be somehow
> embedded within our qsort implementation?
I gave self-tests some thought after David's mail, and honestly I don't
see much value in that, given that we run qsort_chk on everything.
As for embedding, I don't think that's necessary. I prefer to keep them
separate.
Alexander
next prev parent reply other threads:[~2018-05-11 13:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 15:57 [PATCH 0/2] Introduce gcc_qsort Alexander Monakov
2018-05-10 15:57 ` [PATCH 2/2] gcc_qsort: build system changes Alexander Monakov
2018-05-11 9:32 ` Richard Biener
2018-05-10 17:01 ` [PATCH 1/2] gcc_qsort: source code changes Alexander Monakov
2018-05-10 17:01 ` David Malcolm
2018-05-10 17:44 ` Richard Biener
2018-05-10 18:08 ` Alexander Monakov
2018-05-10 18:57 ` DJ Delorie
2018-05-11 12:03 ` Richard Biener
2018-05-11 13:12 ` Alexander Monakov [this message]
2018-05-13 23:56 ` H.J. Lu
2018-05-14 8:44 ` Alexander Monakov
2018-05-14 9:08 ` Richard Biener
2018-05-10 17:35 ` [PATCH 0/2] Introduce gcc_qsort Jakub Jelinek
2018-05-10 17:48 ` Alexander Monakov
2018-05-10 17:43 ` Richard Biener
2018-05-10 17:57 ` Alexander Monakov
2018-05-11 10:35 ` Segher Boessenkool
2018-05-11 10:44 ` Alexander Monakov
2018-05-11 12:00 ` Segher Boessenkool
2018-05-11 12:16 ` Alexander Monakov
2018-05-11 12:52 ` Segher Boessenkool
2018-05-11 16:54 ` Eric Botcazou
2018-05-11 11:17 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.1805111548070.1437@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).