From: Alexander Monakov <amonakov@ispras.ru>
To: Tom de Vries <tdevries@suse.de>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>,
Andrew Stubbs <ams@codesourcery.com>
Subject: Re: [PATCH][libgomp, nvptx] Fix hang in gomp_team_barrier_wait_end
Date: Wed, 21 Apr 2021 20:02:39 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.20.13.2104211948530.19608@monopod.intra.ispras.ru> (raw)
In-Reply-To: <9afc4cec-58de-c941-16d3-a120bd081ce0@suse.de>
On Wed, 21 Apr 2021, Tom de Vries wrote:
> > I don't think implementing futex_wait is possible on nvptx.
> >
>
> Well, I gave it a try, attached below. Can you explain why you think
> it's not possible, or pinpoint a problem in the implementation?
Responding only to this for now. When I said futex_wait I really meant
Linux futex wait, where the API is tied to a 32-bit futex control word
and nothing else. Your implementation works with a gomp_barrier_t that
includes more than one field. It would be confusing to call it a
"futex wait", it is not a 1:1 replacement.
(i.e. unlike a proper futex, it can work only for gomp_barrier_t objects)
Alexander
next prev parent reply other threads:[~2021-04-21 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 11:23 Tom de Vries
2021-04-20 16:11 ` Alexander Monakov
2021-04-21 16:10 ` Tom de Vries
2021-04-21 17:02 ` Alexander Monakov [this message]
2021-04-22 11:11 ` Tom de Vries
2021-04-23 15:45 ` Alexander Monakov
2021-04-23 16:48 ` Tom de Vries
2021-05-19 14:52 ` [PING][PATCH][libgomp, " Tom de Vries
2022-02-22 14:52 ` Tom de Vries
2021-05-20 9:52 ` [PATCH][libgomp, " Thomas Schwinge
2021-05-20 11:41 ` Tom de Vries
2021-11-26 12:10 ` *PING* " Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.13.2104211948530.19608@monopod.intra.ispras.ru \
--to=amonakov@ispras.ru \
--cc=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).