From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95473 invoked by alias); 16 Jul 2015 10:37:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95462 invoked by uid 89); 16 Jul 2015 10:37:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Jul 2015 10:37:34 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48437) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZFgXk-0002Cu-7c for gcc-patches@gnu.org; Thu, 16 Jul 2015 06:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFgXd-0000X5-6L for gcc-patches@gnu.org; Thu, 16 Jul 2015 06:37:31 -0400 Received: from smtp.ispras.ru ([83.149.199.79]:55644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFgXd-0000Vh-0K for gcc-patches@gnu.org; Thu, 16 Jul 2015 06:37:25 -0400 Received: from [10.10.3.121] (unknown [83.149.199.91]) by smtp.ispras.ru (Postfix) with ESMTP id C2E5921578; Thu, 16 Jul 2015 13:37:21 +0300 (MSK) Date: Thu, 16 Jul 2015 10:47:00 -0000 From: Alexander Monakov To: Jiong Wang cc: gcc-patches Subject: Re: [AArch64] Tighten direct call pattern to repair -fno-plt In-Reply-To: Message-ID: References: <1430757479-14241-1-git-send-email-amonakov@ispras.ru> <1430757479-14241-6-git-send-email-amonakov@ispras.ru> <55882EEB.7060207@arm.com> <55895E77.6080305@redhat.com> User-Agent: Alpine 2.20 (LNX 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.79 X-SW-Source: 2015-07/txt/msg01381.txt.bz2 > Attachment is the patch which repair -fno-plt support for AArch64. > > aarch64_is_noplt_call_p will only be true if: > > * gcc is generating position independent code. > * function symbol has declaration. > * either -fno-plt or "(no_plt)" attribute specified. > * it's a external function. > > OK for trunk? > > 2015-07-16 Jiong Wang > > gcc/ > * config/aarch64/aarch64-protos.h (aarch64_is_noplt_call_p): New > declaration. > * config/aarch64/aarch64.c (aarch64_is_noplt_call_p): New function. > * config/aarch64/aarch64.md (call_value_symbol): Check noplt > scenarios. > (call_symbol): Ditto. Shouldn't the same treatment be applied to tailcall (sibcall_{,value_}symbol) patterns? I guess it could be done as a followup patch, but would be nice if that isn't forgotten. Alexander