From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86010 invoked by alias); 14 Jan 2016 14:22:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85996 invoked by uid 89); 14 Jan 2016 14:22:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=DEVICE, iedntifier, consisiting, gompnvptx X-HELO: smtp.ispras.ru Received: from smtp.ispras.ru (HELO smtp.ispras.ru) (83.149.199.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jan 2016 14:22:19 +0000 Received: from [10.10.3.121] (unknown [83.149.199.91]) by smtp.ispras.ru (Postfix) with ESMTP id 5D2D9203FE; Thu, 14 Jan 2016 17:22:16 +0300 (MSK) Date: Thu, 14 Jan 2016 14:22:00 -0000 From: Alexander Monakov To: Martin Jambor cc: GCC Patches , Jakub Jelinek Subject: Re: [hsa merge 05/10] OpenMP lowering/expansion changes (gridification) In-Reply-To: <20160113173925.642670007@virgil.suse.cz> Message-ID: References: <20160113173925.642670007@virgil.suse.cz> User-Agent: Alpine 2.20 (LNX 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2016-01/txt/msg00916.txt.bz2 Hi Martin, while addressing Jakub's feedback can you also fix the typos below? (noticed because I needed to reuse those hunks in gomp-nvptx) On Wed, 13 Jan 2016, Martin Jambor wrote: > +/* Return a target argument consisiting of DEVICE identifier, value identifier > + ID, and the actual VALUE. */ "consisting" > +/* If VALUE is an integer constant greater than -2^15 and smaller than 2^15, > + push one argument to ARGS with bot the DEVICE, ID and VALUE embeded in it, > + otherwise push an iedntifier (with DEVICE and ID) and the VALUE in two > + arguments. */ "both", "embedded", "identifier" Thanks. Alexander