public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Tom Browder <tom.browder@gmail.com>, Ben Elliston <bje@au1.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, doc]: Fix typo.
Date: Sun, 06 Apr 2008 18:54:00 -0000	[thread overview]
Message-ID: <alpine.LSU.1.00.0804062038030.22304@acrux.dbai.tuwien.ac.at> (raw)
In-Reply-To: <1207104443.25017.0.camel@localhost>

On Wed, 2 Apr 2008, Ben Elliston wrote:
>> http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00102.html
> Sorry, Tom, I don't think this qualifies as obvious and I cannot approve 
> it -- this is not an area I am a maintainer of.

When it comes to documentation, we're generally not that strict. :-)

That said: Tom, I believe the patch introduces a number of problems 
coming from too mechanical an approach.

Specifically, in 

 -continues until a non-array type is found, and the qualification of this
 -type is examined.)  So, for example, @code{CP_TYPE_CONST_P} will hold of
 -the type @code{const int ()[7]}, denoting an array of seven @code{int}s.
 +continues until a non-array type is found and the qualification of its
 +type is examined.)  So, for example, @code{CP_TYPE_CONST_P} will hold
 +for the type @code{const int ()[7]}, denoting an array of seven @code{int}s.

the part that replaces "this type" by "its type" doesn't seem right.
And in 

  Used to mark the beginning (if @code{CTOR_BEGIN_P} holds) or end (if
 -@code{CTOR_END_P} holds of the main body of a constructor.  See also
 +@code{CTOR_END_P} holds) for the main body of a constructor.  See also
  @code{SUBOBJECT} for more information on how to use these nodes.

adding the closing parenthesis is a valid fix, but replacing "of" by
"for" does not seem right.

The patch is fine (approved) if you fix these two aspects.

Thanks,
Gerald

  reply	other threads:[~2008-04-06 18:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01  5:34 Ben Elliston
2008-04-01 10:47 ` Tom Browder
2008-04-02  2:47   ` Ben Elliston
2008-04-06 18:54     ` Gerald Pfeifer [this message]
2008-04-07 11:49       ` Tom Browder
2020-04-01 17:19 [PATCH] doc: " Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.1.00.0804062038030.22304@acrux.dbai.tuwien.ac.at \
    --to=gerald@pfeifer.com \
    --cc=bje@au1.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tom.browder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).