From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15575 invoked by alias); 6 Apr 2008 18:45:11 -0000 Received: (qmail 15566 invoked by uid 22791); 6 Apr 2008 18:45:10 -0000 X-Spam-Check-By: sourceware.org Received: from vexpert.dbai.tuwien.ac.at (HELO vexpert.dbai.tuwien.ac.at) (128.131.111.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 06 Apr 2008 18:44:42 +0000 Received: from acrux.dbai.tuwien.ac.at (acrux [128.131.111.60]) by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id A18B239144; Sun, 6 Apr 2008 20:44:37 +0200 (CEST) Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203) id 5AB871004E; Sun, 6 Apr 2008 20:44:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id 4AD0F1004A; Sun, 6 Apr 2008 20:44:39 +0200 (CEST) Date: Sun, 06 Apr 2008 18:54:00 -0000 From: Gerald Pfeifer To: Tom Browder , Ben Elliston cc: gcc-patches Subject: Re: [PATCH, doc]: Fix typo. In-Reply-To: <1207104443.25017.0.camel@localhost> Message-ID: References: <1207027909.8147.1.camel@localhost> <8bc817ee0804010346k5fcd16d5sf8d75b18a3019625@mail.gmail.com> <1207104443.25017.0.camel@localhost> User-Agent: Alpine 1.00 (LSU 955 2008-03-06) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg00501.txt.bz2 On Wed, 2 Apr 2008, Ben Elliston wrote: >> http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00102.html > Sorry, Tom, I don't think this qualifies as obvious and I cannot approve > it -- this is not an area I am a maintainer of. When it comes to documentation, we're generally not that strict. :-) That said: Tom, I believe the patch introduces a number of problems coming from too mechanical an approach. Specifically, in -continues until a non-array type is found, and the qualification of this -type is examined.) So, for example, @code{CP_TYPE_CONST_P} will hold of -the type @code{const int ()[7]}, denoting an array of seven @code{int}s. +continues until a non-array type is found and the qualification of its +type is examined.) So, for example, @code{CP_TYPE_CONST_P} will hold +for the type @code{const int ()[7]}, denoting an array of seven @code{int}s. the part that replaces "this type" by "its type" doesn't seem right. And in Used to mark the beginning (if @code{CTOR_BEGIN_P} holds) or end (if -@code{CTOR_END_P} holds of the main body of a constructor. See also +@code{CTOR_END_P} holds) for the main body of a constructor. See also @code{SUBOBJECT} for more information on how to use these nodes. adding the closing parenthesis is a valid fix, but replacing "of" by "for" does not seem right. The patch is fine (approved) if you fix these two aspects. Thanks, Gerald